Address the issue where the post-processing effects of the new pipeline are unusable. #17568
+27
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
|
Will report error when enabling/disabling builtin-pipeline post processes. Do not merge into v3.8.4 currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This pull request addresses issues with post-processing effects in the new rendering pipeline, focusing on improvements to descriptor set updates and render pass management.
updatePerPassUBOincocos/rendering/custom/define.tsto simplify and enhance texture and sampler binding logiccocos/rendering/custom/executor.tsto improve rendering pipeline execution, particularly for post-processing effectsexecutor.tsfor increased efficiency and flexibilityexecutor.tsto better support the new pipeline structure