Fix the issue where Spine crashes due to container scaling. #17570
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cocos-robot run test cases |
dumganhar
approved these changes
Aug 21, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
|
In addTimer, call shrink_to_fit to ensure that the container's capacity matches its size.
|
|
test-case code: |
|
Minimal code that reproduces the issue: #include <vector>
int main(int argc, const char * argv[]) {
std::vector<int> arr{0, 1,2, 3, 4, 5, 6, 7, 8, 9, 10};
for (auto & e: arr) {
if (e == 5) {
arr.push_back(11);
}
printf("%d, ", e);
}
printf("\n");
return 0;
}Enable AddressSanitizer: |
|
@bofeng-song, Please check the result of
Task Details
|
|
@bofeng-song, Please check the result of
Task Details |
minggo
approved these changes
Aug 21, 2024
|
This bug appeared from v3.6.0 in PR ( minggo/engine-native#442 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
https://forum.cocos.org/t/topic/160784/3
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
This pull request modifies the MiddlewareManager class in the Cocos engine to address a potential crash issue related to Spine and container scaling.
native/cocos/editor-support/MiddlewareManager.cppto replace range-based for loops with index-based loops in update and render methods