Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine particle-simulator-2d.ts: Remove ZERO_VEC2 & misc #17591

Closed
wants to merge 13 commits into from

Conversation

yoki0805
Copy link
Contributor

@yoki0805 yoki0805 commented Aug 31, 2024

Remove ZERO_VEC2 & misc.

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

No significant changes have been made since the previous review. The pull request continues to refine the particle-simulator-2d.ts file with minor optimizations and code consistency improvements.

minggo and others added 5 commits August 23, 2024 14:41
… ineffective. (cocos#17586)

* Fix the issue where post-processing modifications after rendering are ineffective.

* Removes the intensity edit slot for bloom effect
Remove ZERO_VEC2 & clampf.
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Remove misc
@yoki0805 yoki0805 changed the title Refine particle-simulator-2d.ts: Remove ZERO_VEC2 & clampf Refine particle-simulator-2d.ts: Remove ZERO_VEC2 & misc Aug 31, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Aug 31, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -19753,9 +19753,9 @@
         export class frustum extends Frustum {
             constructor();
         }
     }
-    export const VERSION = "3.8.4";
+    export const VERSION = "3.8.5";
     /**
      * @en
      * The main namespace of Cocos engine, all engine core classes, functions, properties and constants are defined in this namespace.
      * @zh

@minggo
Copy link
Contributor

minggo commented Sep 5, 2024

Look good to me. Thanks.
Could you please send it to v3.8.5 as v3.8.4 is releasing.

@yoki0805 yoki0805 changed the base branch from v3.8.4 to v3.8.5 September 5, 2024 12:50
@yoki0805 yoki0805 closed this Sep 5, 2024
@yoki0805 yoki0805 deleted the v3.8.4-particle2d branch September 5, 2024 13:05
@yoki0805
Copy link
Contributor Author

yoki0805 commented Sep 5, 2024

Look good to me. Thanks. Could you please send it to v3.8.5 as v3.8.4 is releasing.

New PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants