[Optimized] upload buffer #17595
Merged
[Optimized] upload buffer #17595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
star-e
reviewed
Sep 3, 2024
cocos/rendering/custom/define.ts
Outdated
Comment on lines
472
to
474
| if (this.buffers.length === 1) { | ||
| return this.buffers[0]; | ||
| } |
There was a problem hiding this comment.
Why is this check needed? I think this.buffers is correctly resized in constructor.
There was a problem hiding this comment.
This is a determination of the array length, not the internal length of the buffer.
There was a problem hiding this comment.
I mean we can remove this guard, the rest of the code still works. I think this is an optimization, because when this.buffers.length === 1, we don't need to do the modulo?
Interface Check ReportThis pull request does not change any public interfaces ! |
minggo
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
star-e
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This pull request optimizes buffer management in the custom rendering pipeline, focusing on improving performance and reducing unnecessary updates. Key changes include:
currUniformproperty inDescBuffManagerclass for more efficient uniform handlingDescBuffManager, simplifying buffer managementidxRDparameter in several functions for improved indexing in buffer-related operationsThese changes should lead to improved rendering performance by reducing buffer operations and optimizing memory usage.