Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 3.8.5 #17603

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Sep 4, 2024

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

This pull request updates the Cocos Creator engine version from 3.8.4 to 3.8.5 across multiple files, indicating a minor version release with potential bug fixes and small improvements.

  • Updated engine version to 3.8.5 in cocos/core/global-exports.ts
  • Modified native/cocos/cocos-version.h to reflect the new version in C++ header
  • Updated package.json with the new 3.8.5 version number

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@@ -25,9 +25,9 @@ THE SOFTWARE.

#define COCOS_MAJOR_VERSION 3
#define COCOS_MINJOR_VERSION 8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: 'MINJOR' is misspelled. Should be 'MINOR'.

Copy link

github-actions bot commented Sep 4, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -19753,9 +19753,9 @@
         export class frustum extends Frustum {
             constructor();
         }
     }
-    export const VERSION = "3.8.4";
+    export const VERSION = "3.8.5";
     /**
      * @en
      * The main namespace of Cocos engine, all engine core classes, functions, properties and constants are defined in this namespace.
      * @zh

@dumganhar dumganhar merged commit e2396b8 into cocos:v3.8.5 Sep 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants