Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with the getClassName error under ES6 #17660

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Sep 23, 2024

Re: #

Changelog

  • When the script is compiled into ES6 syntax, if a function is defined within a class member function, using js.getClassName will retrieve the name of the defined function instead of the class name.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@minggo
Copy link
Contributor

minggo commented Sep 23, 2024

@cocos-robot run test cases

1 similar comment
@knoxHuang
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL SpineMesh,Hexa,puzzle,shield-node
ios PASS PASS FAIL SpineMesh,Hexa,puzzle,shield-node
mac PASS PASS FAIL SpineMesh,Hexa,puzzle,shield-node

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL SpineMesh,Hexa,puzzle,shield-node
android PASS PASS FAIL Hexa,puzzle,shield-node
wechatgame PASS PASS FAIL SpineMesh,Hexa,puzzle,shield-node

@minggo minggo merged commit 84c8a6f into cocos:v3.8.5 Sep 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants