Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release #64

Open
JackAtOmenApps opened this issue May 2, 2021 · 6 comments
Open

New Release #64

JackAtOmenApps opened this issue May 2, 2021 · 6 comments
Assignees

Comments

@JackAtOmenApps
Copy link
Collaborator

Are we ready for a 4.0.0 release with all of the new functionality?

  • There have been 30-odd commits since the last release at the end of 2019
  • This package now has major new functionality with Decimal and re-write of the measurement base
  • All tests and CI checks are passing
  • I hope to submit a PR to finalize updating django-measurement soon, but want to make sure there's an up-to-date release of measurement to call in the package requirements
@codingjoe
Copy link
Collaborator

Hi @OmenApps,

Please, feel free to release at your digression. You are most aware of all changes that have been made.
If you feel it's time for a new release, please do so. Maybe you want to issue a django-measurement release first thought, with updated dependencies, that exclude v4. If you update django-measurement, you can put it to grater than v4.

Otherwise, I see people updating one without the other and spamming you with issues ;)

Best,
Joe

@amotl
Copy link

amotl commented Jun 16, 2022

Hi there,

we arrived here through #70 and #72 and also just responded to an inquiry from @Aran-Fey at #71.

As far as we can see at [1], releasing measurement==4 would not cause any havoc to the downstream django-measurement dependent and its users.

On our work on Wetterdienst, we are occasionally also submitting patches to upstream projects, like filesystem_spec. In this spirit, may we ask what steps would be needed to complete the 4.x release? Can we offer to lend a hand, when needed?

With kind regards,
Andreas.

/cc @gutzbenj

[1] https://github.com/coddingtonbear/django-measurement/blob/3.2.4/setup.cfg#L45

@codingjoe
Copy link
Collaborator

I believe the main problem would be the incompatibility with django-measurement. Maybe we release a 4.0 alpha or RC. On pypi first as well, since it's such a big breaking change.

@amotl
Copy link

amotl commented Jan 10, 2023

Dear Johannes,

first things first, I wish you a happy new year.

On this matter, the pressure is growing, and I think either GH-72 or GH-76 will be needed, and/or a corresponding backport to 3.x, because the runtime dependency sphinxcontrib.applehelp currently breaks the installation, see GH-70, GH-74, and GH-75.

Do you think you can do anything about it?

With kind regards,
Andreas.

/cc @syphar

@codingjoe
Copy link
Collaborator

@amotl I wrote a backport yesterday. v3.2.2 should do the trick

@amotl
Copy link

amotl commented Jan 11, 2023

Thanks a stack for the quick turnaround! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants