Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Issue] Added HTML element messing with video page/player layout #1640

Closed
BrainOnEggs opened this issue Mar 26, 2023 · 6 comments
Closed
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle)

Comments

@BrainOnEggs
Copy link

BrainOnEggs commented Mar 26, 2023

Bug Report:

BUG:

When clicking on a video from a new YouTube homepage tab, the opened video player (and video progress bar) will be slightly cut on the right and bottom of the player.

Below is an example of an affected video page

image

The cause of this issue seems to be due to an added HTML element

image

with the offending element being the highlighted one.

HOW:

Open a new YouTube homepage tab by either middle clicking the logo, or by opening a new tab and entering "youtube.com" into the URL bar. From there simply click on any YouTube video and that'll/should do it.

This issue only happens when I'm signed into YouTube.

EDIT: Here's a video of me reproducing the issue

2023-03-27.04-59-14_Trim_Trim_compressed.mp4

EXPECTED (/preferred) behavior:

Below is a screenshot of the same video page as before, but fixed

image

And a screenshot of how the HTML elements should look like

image

It becomes much easier to see the difference between video page screenshots when looking at the bottom right of the video player in both images.

Reloading the page seems to fix the issue, at least, until a new YouTube home page is opened.

This is obviously a minor issue, but I doubt it would hurt to at least bring it up.

Setup:

⚬ ImprovedTube Version: 4.5
⚬ Browser: Brave Version 1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)

(though I have tested with a few other browsers and nothing changed between them, so take that as you will.)

⚬ OS: Windows 10

@BrainOnEggs BrainOnEggs added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Mar 26, 2023
@ImprovedTube
Copy link
Member

thanks @BrainOnEggs
not so minor, we gotta research it

@ImprovedTube
Copy link
Member

i think it was another symptom of a bug fixed (#1624)
so we can try the repo master https://github.com/code-for-charity/ImprovedTube-for-YouTube/archive/refs/heads/master.zip
or wait for the store version to be approved.

@BrainOnEggs
Copy link
Author

bleh. Closed this too early cause the extension updated to 4.6 (store). but having tested it, it didn't go away. I also tried the repo master and that didn't fix it either. So now I'm reopening. Sorry about that.

@BrainOnEggs BrainOnEggs reopened this Mar 27, 2023
@BrainOnEggs
Copy link
Author

Added a video of me reproducing the issue to the initial report

@ImprovedTube
Copy link
Member

thanks @BrainOnEggs! couldnt reproduce it yet.

@ImprovedTube ImprovedTube added the Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle) label Mar 28, 2023
@BrainOnEggs
Copy link
Author

Alright, as of version 4.8 the issue is gone (Though, I'm not sure if the issue was still in 4.7 or not. I wasn't paying attention at that time.), and as such, I'll close the issue. And this time, I made sure that it wasn't able to be reproduced. Great extension by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Open! Not to forget. Unfinished (or waiting for a requirement) (unless combined with label: riddle)
Projects
None yet
Development

No branches or pull requests

2 participants