-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autplay not working. Ver 4.820 #2137
Comments
Are you sure this is ImproveTube. If anything ImproveTube has trouble pausing videos in the first place. |
I did. I uninstalled all extensions except IT and nothing changed. I uninstalled IT and kept all my other extensions, and YT videos started auto playing. I tried it with both their main and Beta extensions - the result was the same. I finally decided to permanently remove this extension from my browser. It's wonderful, but I really loathe having to manually click play on 20+ videos on a daily basis. |
Did you switch Autoplay in options of ImproveTube? The only way for ImproveTube to do anything to video playback is for you to switch Autoplay off first. |
I tried both on and off for autoplay. Didn't work for either
…On Monday, April 8, 2024, Rasz_pl ***@***.***> wrote:
Did you switch Autoplay in options of ImproveTube? The only way for
ImproveTube to do anything to video playback is for you to switch Autoplay
off first.
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLZPK3HQQL4OTP5MDEULLTY4JNCRAVCNFSM6AAAAABFQSNFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSGI2DIMJZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have the same issue - or a similar one. I first suspected my uBlock Origin extension but the error indeed only goes away, once I disable ImproveTube. |
Funny. I reinstalled the app and removed Ublock and noticed that videos in
the same tab will autoplay, but when opened in a new tab, they don't play
One of the devs said this isn't an issue from their end, so I'm not sure
what more can be done at this point
…On Fri, Apr 19, 2024 at 5:31 PM MRiCEQB ***@***.***> wrote:
I have the same issue - or a similar one.
Whenever I go on YouTube and find several videos I want to watch, I use
the middle mouse button to open them in individual tabs.
In the past they started to autoplay, once I selected the desired tab -
now they are always on pause.
This doesn't happen when I open a video right away (left mouse button).
I first suspected my uBlock Origin extension but the error indeed only
goes away, once I disable ImproveTube.
If you require any logs or something, please let me know.
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLZPK3AIXVXTSFTBUFQG4TY6EBRDAVCNFSM6AAAAABFQSNFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGQZDIMZZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
When you now disable ImprovedTube, does it autoplay in the next tab? |
yup. seems like the default youtube setting.
…On Thu, Apr 25, 2024 at 10:39 AM MRiCEQB ***@***.***> wrote:
When you now disable ImprovedTube, does it autoplay in the next tab?
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLZPK25XRE4FPBERAFM4HLY7CFYVAVCNFSM6AAAAABFQSNFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWGM3DMMZYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
So (at least to my understanding) ImprovedTube does something, that causes this behavior. |
Default youtube setting is ALL videos Pause when opened in background tab, but start autoplaying when you click on that tab and make it active/visible. |
Correct and this behavior does not work for us, as long as ImprovedTube is active. |
hi, please open the browser console when (before or after) the issue happens to copy any errors or log message from us (not those from Youtube or third parities) |
This is a bit tricky to catch, because the console needs to be activated for each tab (as fas as i can tell). |
console doesnt need to be open prior to log errors. there are no errors in your log file |
I'm using Chrome. |
thank you! @MRiCEQB @sonal-g123 @Jerrk @CodeClimberNT @Sidonly @DrNopt killthe3vil @Evoden1 @xeophyte ( then we can compare further which might be the reason March
December
December
#2136 (with @Jerrk's ctrl+u.txt already ) |
I did the result twice, once when the problem occurs and then another time after clearing cookies and the problem is gone. I ran a diff check on both of them and there is no difference |
Just as an FYI I had to format and reinstall my Windows 11 and most of the problem were fixed (not all of it!), anyway those are my flags: experimental-flags.json. |
edit: hi @xeophyte! Can type console prompts just below, after the ">" |
https://gist.github.com/Evoden1/747254eb676cf5da1a4f8044dbe64757 the yt.config_.EXPERIMENT_FLAGS result |
I'm glad other people spoke up about this issue. Previously, I was the only
one and Admin told me that they weren't facing thay issue from their end,
and that was that.
…On Saturday, April 27, 2024, Evoden1 ***@***.***> wrote:
https://gist.github.com/Evoden1/747254eb676cf5da1a4f8044dbe64757
the yt.config_.EXPERIMENT_FLAGS result
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLZPK3X5ATWAARK67SILCDY7LD3JAVCNFSM6AAAAABFQSNFC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGE3DGNJUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ok, since we have couple of you here able to trigger this reliably. Experiment:
edit: hi @raszpl! applies with unzipped "developer mode" installations. If it was installed from the webstore, modifying and reloading an extension will be noticed as corrupted and won't load. |
I deleted |
last test. Edit original \js&css\web-accessible\www.youtube.com\player.js
to
and js&css\web-accessible\functions.js line 340 |
Yes. With
when not clicking the player to play and
after clicking the play. |
sorry, I was still editing last message. Try that , in theory should be fixed |
#2137 (comment) works for me. |
can you test if switching autoplay to off in extension options(player section) also works for you? just a quick toggle and couple of refreshes. Its not 100% reliable now because sometimes YT tries to autoplay several times, in that case you can try commenting out Hopefully it will be fixed in next release |
Yes, autoplay off also works. Tested on few videos with many refreshes and nothing played. Same with |
i did it and now autoplay works on Firefox Beta |
I toggled it off, and the video pauses after the page loads I toggled it on, and the autoplay function works perfectly |
I'm glad it seems to have been figured out :) Would this also fix my issue #2136 where the fullscreen and playback speed isn't applied either? since it seems to me that the cause is the same where the player element isn't loaded in time and crashes the script |
I thought it would solve my other problem but it didn't #1867 |
not directly, both fullscreen and playback speed functions appear to check for existence of player element being set properly, but its possible autoplay was crashing whole extension before those could be applied.
wasnt that in Vivaldi? I cant reproduce this problem in Vivaldi :( The thing that can fix it is commenting out |
I did the changes in #2137 (comment) and autoplay now works. toggling it on/off also works. The change doesn't appear to affect the auto fullscreen setting nor the playback speed though. |
wow! 65 comments!
💭 if ImprovedTube.elements.player can be undefined, we have something to research! ❤️let tries=0;
(function waitForVideo(){
if(ImprovedTube.elements.player
|| ImprovedTube.elements.player = document.body.closest('#movie_player')){ return;
}else if(tries++<101) {setTimeout(waitForVideo,50); if(console.log("waiting for #movie_player");
}else if(tries===101) {console.error("resigning to wait for #movie-player after > 5s")}
})()
document.addEventListener("DOMContentLoaded", () => tries = 101);
Chrome does too afaik for the web-accessible files. @raszpl Experiment Flags:
thank you! @Jerrk
That would teach us what part of youtube is required for the bug, if we compare your experiment flags ( @xeophyte logged in & logged out, to see which might change when you log out. #2137 (comment) )
thanks! @Evoden1. (logged in?) previously: |
I dont think its experimental flags, it might be FFs different JS engine combined with caching (YT serviceworker) letting YT initialize faster thus outpacing improvetube terrible mechanism of walking all nodes in childHandler youtube/js&css/web-accessible/functions.js Lines 171 to 173 in f92b508
Sadly improvetube has at least a few timing assumptions that only hold by sheer luck :) like #1803 (comment)
But I dont think you can run a function that would show it in Chrome due to the way Javascript event loop works. I think its only showing up in Firefox due to JS engine differences, FF one is somehow more/less aggressively serializing and somehow calling play() before mutationObserver triggers. |
then we can adjust and/or report something to firefox
one error can have multiple requirements (even we don't always need to know all of them) (Or "working when logged out" was a coincidence, deleting cookies too, just like disabling autoplay-off) |
Yes logged in |
Doesn't seem to be fixed in 4.921. |
Is there any way I can install the latest improvetube version on Firefox permanently and not as a as a temporary add-on? I downloaded Firefox Nightly and did this: and tried to install Improvetube zip I don't want to self-sign the extension is there any other way? |
nvm I did it I had to put a random email in the manifest ID. and repacked the zip and brought the manifest and other files to root level and not inside youtube-4.920. |
I dont know when 4.921 was build, code looks 2 weeks old? its pre #2210 |
I don't know, updated 10.05 on chrome webstore |
= just 4.805. Rolled back from 4.920 because it had 100+ uninstalls in the first hour https://improvedtube.com/uninstalls-hours-days-usatime-updated-every-3-minutes . Google just added such immediate rollback (amazingly late, while other extensions can be worth billions, like honey) Mozilla Firefox might takes some days to release the 4.920rev4
named .xpi? @Evoden1 |
no zip I modified the zip (from github releases) by moving the manifest and everything to root level, not inside youtube-4.920. |
hi! @Evoden1 @sonal-g123 @Jerrk @CodeClimberNT @xeophyte |
By autoplay, I mean the video I click on, not the videos lined up in my playlist. This play button has not been working for months now and I have to manually click on the "play" button on the 20+ videos I watch daily
Not sure if this is a bug or if it's bc of YT's changed algorithm, but is it possible to take a look at it?
Thank you <3
The text was updated successfully, but these errors were encountered: