Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Dark mode text entry field fonts impossible to see #2733

Open
zweidrache opened this issue Dec 15, 2024 · 2 comments
Open

🐞Dark mode text entry field fonts impossible to see #2733

zweidrache opened this issue Dec 15, 2024 · 2 comments
Labels
Bug Bug or required update after YouTube changes CSS Solution can be CSS ( /mostly - if any JS is needed, please specify) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ YouTube changed

Comments

@zweidrache
Copy link

Concise Description

I haven't checked every single text field possible on the entire site, but ever since the last few days I noticed that the font color for text inside fields such as Comments for the Video and Shorts feed comments sections, and the title field for the popup for when you try to create a Clip are completely unreadable.

I've included screenshots for all three showing where you can see the red squigly line for the spellcheck but the text itself is black-on-black (or dark dark grey) for all and then I highlighted each bit of text to prove something was indeed in the field. this makes it nearly impossible to actually use these fields in any capacity.

Fields that seem to still work properly: Search field (main pages, history page, channel pages), the Playlist editor, and fields on the various YouTube Studio pages.

(Note: most of these cannot be tested logged out since the relevant fields will only work when logged into an account.)

Shorts feed:
image
image

Normal video page:
image
image

Clip maker popup:
image
image

Browser/s

Brave

Other Browser:

No response

'Steps to reproduce' - Which of our features is required for the bug to happen?

Activate any Theme in the extension where the page background is black (e.g.: Black, Youtube's Dark, etc)

Since when?

Unsure. I see the last release was 3 weeks ago but this feels like it was much more recent.

Does the bug still happen when you log out of YouTube?

None

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

No response

Are any errors or related log-messages shown in the Browser-Console? (F12)

No response

Tested as the only active extension? (incognito mode or another browser users):

None

Expected preferred behavior:

Text should be white (or other alternative light color) to show against dark backgrounds.

ImprovedTube Version

4.1122

Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings)

{"below_player_loop":true,"below_player_pip":false,"below_player_screenshot":false,"channel_default_tab":"/videos","channel_trailer_autoplay":false,"chapters":false,"custom_player_size_height":"900","custom_player_size_width":"1600","forced_theater_mode":false,"ga":1668368995359,"header_hide_country_code":false,"header_hide_right_buttons":false,"header_improve_logo":false,"header_position":"hover_on_video_page","hide_footer":true,"hide_gradient_bottom":true,"hide_playlist":false,"hide_shorts_remixing":false,"hide_voice_search_button":false,"lastDarkTheme":"dark","limit_page_width":true,"livechat":"hidden","mark_watched_videos":true,"no_page_margin":false,"player_ads":"block_all","player_autoplay_disable":true,"player_hamburger_button":false,"player_popup_button":false,"player_quality":"hd1080","player_remaining_duration":false,"player_show_cards_on_mouse_hover":true,"player_size":"do_not_change","player_subtitles":false,"player_transparent_background":false,"related_videos":"normal","sidebar_left":false,"subtitles_language":"en","theme":"dark","thumbnails_hide":false,"thumbnails_right":false,"up_next_autoplay":false,

Your YouTube-Document

No response

OS / Device:

Windows 10

@zweidrache zweidrache added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 15, 2024
@ImprovedTube ImprovedTube added YouTube changed CSS Solution can be CSS ( /mostly - if any JS is needed, please specify) labels Dec 16, 2024
@ImprovedTube
Copy link
Member

hi! and thanks @zweidrache
we can add input { color: white } to our dark theme's CSS. (or alternatively precisely refer to one of our variables for the theme/s)

for Youtube's dark theme our extension shouldn't do anything,
except maybe here:

/*------------------------------------------------------------------------------
YT hardcoded CSS for DARK/light mode switching
Need HTML in front to make CSS rule more specific than one they are overiding
------------------------------------------------------------------------------*/

(while the file refers to [data-system-color-scheme=dark] 32 times and 5x (not:[it-theme=dark]) )

@zweidrache
Copy link
Author

hi! and thanks @zweidrache we can add input { color: white } to our dark theme's CSS. (or alternatively precisely refer to one of our variables for the theme/s)

do you perhaps have CSS I can add to UBO as a rule? I can then test if that fixes it on my end, and report back my results with screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes CSS Solution can be CSS ( /mostly - if any JS is needed, please specify) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ YouTube changed
Projects
None yet
Development

No branches or pull requests

2 participants