Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve the captions settings ui and add keyboard shortcuts to change font size #1526

Open
1 of 3 tasks
Gourav-21 opened this issue Oct 29, 2024 · 4 comments
Open
1 of 3 tasks
Labels
enhancement New feature or request

Comments

@Gourav-21
Copy link

Gourav-21 commented Oct 29, 2024

Current UI
The settings of caption looks really bad and there is no shortcut to change the size of fonts while watching the video, i have to open the settings everytime to change the size.

image

Suggestions

  • improve the ui of caption settings
  • add shortcuts to change size of font like its on youtube using - and +
  • and add support for numpad to go forward and backward in video
@Gourav-21 Gourav-21 added the enhancement New feature or request label Oct 29, 2024
@shahkashish
Copy link

To tackle the 2nd enhancement i.e. "add shortcuts to change size of font like its on youtube using - and +", we will have to

  1. Add a State for current Subtitle Font Size.
  2. Attach a keydown event listener to the component to capture the + and - keys.
  3. Dynamically adjust the font size of the subtitles according to the current state of subtitle and the key that is pressed.
    above steps would let us complete the task

@shahkashish
Copy link

If you like the approach lmk and i'll start working on it, even if you have different views you can tell me.

@Gourav-21
Copy link
Author

@shahkashish yeah please go on

@shahkashish
Copy link

could you assign it to me?
as it is mentioned that task should be assigned first and then i have to make PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants