Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AutoPTS #5

Open
5 tasks
michal-narajowski opened this issue Mar 9, 2021 · 0 comments
Open
5 tasks

Refactor AutoPTS #5

michal-narajowski opened this issue Mar 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@michal-narajowski
Copy link

The project could use a large refactor. I have a few ideas:

  • Get rid code duplication - We don't need to list every test case that is supported. A PTS workspace contains all supported test cases. By default we should have some generic wid handler that is common to all platforms and maybe some preconditions (some requirements for test case are not communicated through wids). If a platform needs some specific behavior then it should be implemented but 90% of the time it would be just default handlers and this removes a lot of code. After this change adding support for new platforms would be much easier (to implement, to test and to review).
  • Get rid of globals - This makes the dependencies complicated and adding new features is problematic. The design is not clean. As an example: iutctl.
  • Get rid of ZTestCase - It should be made more generic.
  • Split btp.py into multiple files - This file is huge and indexing it takes a lot of time.
  • Merging bot client and regular client - We could have a single client that has all the features of a bot client and the ease of use of the regular one. We could move platform specific stuff to iutctl or some other module that is implemented by each platform. We could add command line options to bot that will allow to override some settings that are specifiec in configuration file. So the default would be a config file but if we want we could specify CLI options and it will behave just like the regular client.
@michal-narajowski michal-narajowski added the enhancement New feature or request label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant