Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak how CLI gets the branch name for tokenless #2065

Open
matt-codecov opened this issue Jul 11, 2024 · 1 comment · May be fixed by codecov/codecov-cli#475
Open

Tweak how CLI gets the branch name for tokenless #2065

matt-codecov opened this issue Jul 11, 2024 · 1 comment · May be fixed by codecov/codecov-cli#475
Assignees

Comments

@matt-codecov
Copy link

Currently the GHA will set a $TOKENLESS env var and the CLI will read from it.

If there's no token and $TOKENLESS is not set, the CLI will error out. That means you can't use the normal way to override the branch (-B) for tokenless, you need a unique way just for this case. That's kind of counterintuitive.

IMO, we could get rid of the $TOKENLESS env var and make the GHA just use -B, and then change the CLI logic to be:

if not token and ':' not in branch:
    print("nuh-uh")

(Alternatively, we could make the CLI figure out the unprotected branch name on its own)

@matt-codecov
Copy link
Author

@joseph-sentry @trent-codecov could we try to close this issue by finishing codecov/codecov-cli#475 and codecov/codecov-action#1511 next sprint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants