-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Upload processing status UI component #2522
Comments
@thomasrockhu-codecov @trent-codecov can you assign this issue? |
I reviewed the upload processing status UI with @trent-codecov and @rohan-at-sentry, and Trent checked our database to confirm we have the data available to display in the UI so this issue might not need platform work. We will wait until @spalmurray-codecov works on this issue to see if he has all the resources he needs. No action needed for now. |
Synced with @spalmurray-codecov on 10/4:
|
Hi @spalmurray-codecov, why this issue is blocked? Can you share the reason? |
Hi @Adal3n3! This is blocked as I am figuring out a solution to the estimation problem. Here's the doc that I got some feedback on- https://www.notion.so/sentry/Estimating-the-expected-number-of-uploads-for-a-commit-1318b10e4b5d80228157e81fed87dd7f I need to think a little more about the solution here before we can continue. That said, I think it makes sense to make this a Q4 OKR though. There's enough work here to warrant a sprint or two of work no matter what we decide for solution. |
Thank you @spalmurray-codecov for sharing the blocker. We only want this 'processing upload' component to display while uploads are in progress and uploads completed with error(s), but we don’t have a way to determine when uploads are complete. [This is not a blocker] Without the data for estimation of uploads, we can deliver a v1 solution with a static width for all statuses, including the gray bar. This means all statuses will display at 100% width and won’t visually represent "progress". In v2, we can explore using the previous upload count as an estimate for the gray bar. V1 solution: without estimation of uploads (cc @codecovdesign ) |
This issue has a dependency on #2702 to figure out the start and end state of processing uploads. We want to understand if it's possible to determine the start/end of processing uploads as an initial next step. |
Blocked pending #2921 |
@spalmurray-codecov We still can communicate to the user without showing the estimation of uploads. I believe the true blocker here is without knowing the start and end state of processing uploads, we don't know when to show the upload processing status UI. |
Follow up the discussion from here #2702 (comment) Figma: https://www.figma.com/design/4Z7yb2dkIIATkfzpWoMYQq/GH-2220?node-id=1-2 |
Figma link: https://www.figma.com/design/4Z7yb2dkIIATkfzpWoMYQq/GH-2220?node-id=1-2
Customers will see the upload processing status in these two scenarios:
1/ uploading reports
2/ uploaded(processed) report has an error
Location "3":
The text was updated successfully, but these errors were encountered: