Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Upload processing status UI component #2522

Open
Tracked by #2220
Adal3n3 opened this issue Sep 16, 2024 · 10 comments
Open
Tracked by #2220

Implement the Upload processing status UI component #2522

Adal3n3 opened this issue Sep 16, 2024 · 10 comments
Assignees
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.

Comments

@Adal3n3
Copy link

Adal3n3 commented Sep 16, 2024

Figma link: https://www.figma.com/design/4Z7yb2dkIIATkfzpWoMYQq/GH-2220?node-id=1-2

Customers will see the upload processing status in these two scenarios:
1/ uploading reports
2/ uploaded(processed) report has an error

Location "3":
Image

Image

Image

@Adal3n3 Adal3n3 added the Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. label Sep 16, 2024
@Adal3n3
Copy link
Author

Adal3n3 commented Sep 16, 2024

@thomasrockhu-codecov @trent-codecov can you assign this issue?

@Adal3n3
Copy link
Author

Adal3n3 commented Sep 19, 2024

I reviewed the upload processing status UI with @trent-codecov and @rohan-at-sentry, and Trent checked our database to confirm we have the data available to display in the UI so this issue might not need platform work. We will wait until @spalmurray-codecov works on this issue to see if he has all the resources he needs. No action needed for now.

@Adal3n3
Copy link
Author

Adal3n3 commented Oct 4, 2024

Synced with @spalmurray-codecov on 10/4:

  • confirmed that we are good and ready to implement the upload processing status UI.
  • The grey bar that indicating we are still waiting for uploads, we can use an estimate timestamp.
  • @Adal3n3 will open a new issue for the code snippet. We can display the code snippets as soon as we detect an error, so users don't have to wait for the entire processing to finish.
  • Without the code snippets, just the processing status UI, takes 3-5 days eng work.
  • For Code snippet - unknown but might take 3-5 days eng work.

@Adal3n3
Copy link
Author

Adal3n3 commented Nov 13, 2024

Hi @spalmurray-codecov, why this issue is blocked? Can you share the reason?

@spalmurray-codecov
Copy link

Hi @Adal3n3! This is blocked as I am figuring out a solution to the estimation problem. Here's the doc that I got some feedback on- https://www.notion.so/sentry/Estimating-the-expected-number-of-uploads-for-a-commit-1318b10e4b5d80228157e81fed87dd7f

I need to think a little more about the solution here before we can continue.

That said, I think it makes sense to make this a Q4 OKR though. There's enough work here to warrant a sprint or two of work no matter what we decide for solution.

@Adal3n3
Copy link
Author

Adal3n3 commented Nov 13, 2024

Thank you @spalmurray-codecov for sharing the blocker. We only want this 'processing upload' component to display while uploads are in progress and uploads completed with error(s), but we don’t have a way to determine when uploads are complete.
--> Next steps: I’ll set up a meeting to explore possible solutions with the team.

[This is not a blocker] Without the data for estimation of uploads, we can deliver a v1 solution with a static width for all statuses, including the gray bar. This means all statuses will display at 100% width and won’t visually represent "progress". In v2, we can explore using the previous upload count as an estimate for the gray bar.

V1 solution: without estimation of uploads
Image

(cc @codecovdesign )

@Adal3n3
Copy link
Author

Adal3n3 commented Nov 13, 2024

This issue has a dependency on #2702 to figure out the start and end state of processing uploads. We want to understand if it's possible to determine the start/end of processing uploads as an initial next step.

@spalmurray-codecov
Copy link

Blocked pending #2921

@Adal3n3
Copy link
Author

Adal3n3 commented Dec 3, 2024

@spalmurray-codecov We still can communicate to the user without showing the estimation of uploads. I believe the true blocker here is without knowing the start and end state of processing uploads, we don't know when to show the upload processing status UI.

@Adal3n3
Copy link
Author

Adal3n3 commented Dec 17, 2024

Follow up the discussion from here #2702 (comment)
We currently do not have distinct states for the start and end of upload processing, but we do have a processing state to indicate that an upload has started. The challenge is that we don’t know precisely when an upload is complete, so displaying a "processing" UI alongside the coverage report could be misleading. As an alternative, we propose communicating pending uploads by displaying the number of uploads in progress. (cc @spalmurray-codecov )

Figma: https://www.figma.com/design/4Z7yb2dkIIATkfzpWoMYQq/GH-2220?node-id=1-2

Image


Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.
Projects
None yet
Development

No branches or pull requests

2 participants