Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust_base Does not seem to be correctly calculating. #463

Closed
drazisil-codecov opened this issue Jul 29, 2024 · 1 comment · Fixed by codecov/worker#743
Closed

adjust_base Does not seem to be correctly calculating. #463

drazisil-codecov opened this issue Jul 29, 2024 · 1 comment · Fixed by codecov/worker#743
Assignees
@giovanni-guidini
Labels
Area: Report Processing Issues with report processing bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) investigation

Comments

@drazisil-codecov
Copy link

drazisil-codecov commented Jul 29, 2024 •
edited
Loading

Here is another case where the report seems to calculate something strange: xmldom/xmldom#698 (comment)

Image

Not sure how it is calculated, but when 6 lines and one branch are being removed, they can of course also no longer be hit?

Or am I misunderstanding something?

I even added/extended tests in that commit.

Originally posted by @karfau in #8

@karfau I agree with you, after taking a look. @rohan-at-sentry is this a bug, or some part of the system that needs better docs?

https://app.codecov.io/gh/xmldom/xmldom/pull/698?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=xmldom is the only changed file, and it shouldn't fail project, given it's 100% covered.

Originally posted by @drazisil-codecov in #8
@drazisil-codecov drazisil-codecov added bug For issues and unexpected behaviors investigation labels Jul 29, 2024
@drazisil-codecov drazisil-codecov mentioned this issue Jul 29, 2024
Open
@drazisil-codecov drazisil-codecov added the High High Priority Issues (to be fixed within 2 sprints) label Aug 1, 2024
@eliatcodecov
Copy link
Contributor

Difficult to determine if this is potentially a systemic issue with adjust_base or just unique to this repo somehow. Work would be to audit adjust_base and ensure it's working as expect.

@rohan-at-sentry rohan-at-sentry added the Area: Report Processing Issues with report processing label Aug 13, 2024
giovanni-guidini added a commit to codecov/worker that referenced this issue Sep 26, 2024
@giovanni-guidini
fix: adjust_base behavior
552937a 
The math was not math-ing (i.e. it would only work if the difference between BASE and HEAD
was within 0.01, in absolute value)
Now the math allows the HEAD to be infinitely greater than the base when suceeding.

Added better tests as well. Reduced wiggle room to 0.005.

closes codecov/feedback#463
@giovanni-guidini giovanni-guidini mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovanni-guidini giovanni-guidini

Labels
Area: Report Processing Issues with report processing bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) investigation
Projects
GitHub Issues with 👀
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust_base behavior codecov/worker
4 participants
@drazisil-codecov @eliatcodecov @giovanni-guidini @rohan-at-sentry