Can't POST Id as Number (without quotes)

[wwdenis]

Summary

It's not possible to to POST/PUT a body with Id as a number (without quotes).

Steps to Reproduce

Reason

I am using Swashbuckle. to for documentation, and Ids are documented without quotes.

Configuration

• TargetFramework: netcoreapp2.2
• JsonApiSerialiser: 1.7.3
• Newtonsoft.Json: 12.0.2

Sample Code

Model

class CityModel 
{
    public int Id { get; set; }
    public string Type { get; set; }
    public string Name { get; set; }
}

Controller

[Route("api/cities")]
[ApiController]
public class CityController : ControllerBase
{
    [HttpGet("{id}")]
    public IActionResult Get(int id)
    {
        var item = new CityModel
        {
            Id = id,
            Name = "Test"
        };

        return Ok(item);
    }

    [HttpPost]
    public IActionResult Post([FromBody] CityModel model)
    {
        return Ok($"RECEIVED: {model.Id}");
    }
}

Startup

public class Startup
{
    public Startup(IConfiguration configuration)
    {
        Configuration = configuration;
    }

    public IConfiguration Configuration { get; }

    public void ConfigureServices(IServiceCollection services)
    {
        services.AddMvc(opt => EnableJsonApi(opt, services));
    }

    public void Configure(IApplicationBuilder app, IHostingEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
        }

        app.UseMvc();
    }

    private static void EnableJsonApi(MvcOptions options, IServiceCollection services)
    {
        var serviceProvider = services.BuildServiceProvider();
        var objectPoolProvider = serviceProvider.GetService<ObjectPoolProvider>();
        var loggerFactory = serviceProvider.GetService<ILoggerFactory>();
        var logger = loggerFactory.CreateLogger<JsonInputFormatter>();

        var serializerSettings = new JsonApiSerializerSettings();
        var charPool = ArrayPool<char>.Shared;

        var outputFormatter = new JsonOutputFormatter(serializerSettings, charPool);
        var inputFormatter = new JsonInputFormatter(logger, serializerSettings, charPool, objectPoolProvider, options, null);

        options.OutputFormatters.RemoveType<JsonOutputFormatter>();
        options.InputFormatters.RemoveType<JsonInputFormatter>();

        options.OutputFormatters.Insert(0, outputFormatter);
        options.InputFormatters.Insert(0, inputFormatter);
    }
}

[alex-davies]

The json:api spec explicitly states id must be a string (https://jsonapi.org/format/#document-resource-object-identification) so passing id as an int the json is not technically valid json:api.

The values of the id and type members MUST be strings.

There was a feature where we allow the serializer to handle int id on the class and we handle the mappings to/from string for you, but it doesn't change the format of id on the wire

[AndreSteenveld]

Event though this is a ticket about the identifier in a json-api document this is the most complete example of JsonApiSerializer I could find.