Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When logged in, no h1 element present #519

Open
milofultz opened this issue Nov 15, 2023 · 2 comments
Open

Bug: When logged in, no h1 element present #519

milofultz opened this issue Nov 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@milofultz
Copy link
Contributor

Bug Description:

When logged in, viewing the page with "Contacts"/"Civic Profile" tabs, there is no h1 for the page.

Reproduction Steps:

1. Log in.
2. On next page when logged in, check the DOM.

Expected Behavior:

There should be an h1 that "describes the content of the page (similar to the document's <title> element)" (from MDN).

Possible Solution (optional):

Add an h1 that describes the content of the page. Don't know if it should be for the entire page (including the tabbed areas of "Contacts"/"Civic Profile") or just the tab themselves. Think it should probably be the whole page.

@xscottxbrownx
Copy link
Contributor

They are currently two separate pages.

Screenshot 2023-11-21 at 9 37 18 AM Screenshot 2023-11-21 at 9 33 41 AM

@leekahung
Copy link
Contributor

They are currently two separate pages.

That's right. Currently how the site is set up so that "Contacts" is in a separate page with the contacts list and "Civic Profile" will be on their own page with profile information. The two pages can be accessible via the navbar which consist of MUI tabs linking the pages to their respective routes (/contacts and /civic-profile as Scott pointed out in the image of src/AppRoutes.jsx).

So if we were to improve the site with h1 elements for accessibility, think we'll needed them each of the pages, one for "Contacts" and one for "Civic Profile". As for what elements to utilize, I think the recently implemented breadcrumbs would be a good choice since the trailing crumb would typically display the name of the route they've entered.

Screen Shot 2023-11-21 at 12 49 30 Screen Shot 2023-11-21 at 12 49 45

The only part which this might not work would be under contacts since the breadcrumb there utilizes the contact's full webId as the crumb. We'll probably need an alternative for that edge case.

Screen Shot 2023-11-21 at 12 51 51

@leekahung leekahung added the bug Something isn't working label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants