Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] - Disallow submitting forms that have no input #629

Open
andycwilliams opened this issue May 9, 2024 · 2 comments
Open

[Discovery] - Disallow submitting forms that have no input #629

andycwilliams opened this issue May 9, 2024 · 2 comments
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features

Comments

@andycwilliams
Copy link
Member

andycwilliams commented May 9, 2024

Note: This issue is marked for discovery. It is open for discussion and not necessarily decided upon.

Describe the Current Behavior/Feature:

Some of the forms we have allow for submission/confirmation despite having no input or changes being made.

Share Documents modal:

2024-05-09 (4)

Civic Profile Housing form:

2024-05-09 (2)

Rationale:

It doesn't really make sense to allow this. Besides, we already disallow it elsewhere. See:

2024-05-09 (3)

Proposed Changes:

Disable these submission buttons when there is no input.

Possible Drawbacks:

User may want to clear the data they already submitted. Currently that functionality is not in place. Only Basic Information has a clear button but that only clears the current inputs and does not remove the data itself. Housing Information only has a submit button and Financial Information still needs to be created.

@andycwilliams andycwilliams added enhancement Enhancement of existing features good first issue Good for newcomers discovery Open discussion and exploration of topic on hand and removed good first issue Good for newcomers labels May 9, 2024
@rdhss
Copy link

rdhss commented May 11, 2024

hello, can i work for this issue?

@leekahung
Copy link
Contributor

leekahung commented May 11, 2024

Think we should do this only for some of the forms where there are required fields like the share documents form. For forms like the Civic Profile forms, all the fields in it are meant to be optional (see issue #442) so they should be able to accept submissions with no input.

If we wish to still have the submit button disabled, we should instead check if any of the fields are changed rather than a blanket disable based on whether there is an input. So, if input is changed, allow submit, else disable it.

So we should check which forms needs this feature.

@andycwilliams andycwilliams changed the title [Enhancement] - Disallow submitting forms that have no input [Discovery] - Disallow submitting forms that have no input May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features
Projects
None yet
Development

No branches or pull requests

3 participants