Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] - Resize loading animations to fit spaces #643

Open
andycwilliams opened this issue May 27, 2024 · 0 comments
Open

[Discovery] - Resize loading animations to fit spaces #643

andycwilliams opened this issue May 27, 2024 · 0 comments
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features

Comments

@andycwilliams
Copy link
Member

Note: This issue is marked for discovery. It is open for discussion and not necessarily decided upon.

Describe the Current Behavior/Feature:

Currently, when loading the Contacts and Profiles/Documents pages, the animation is much smaller than the final content size.

Profile:
2024-05-26 (4)
2024-05-26 (5)

Contacts:
2024-05-26 (6)
2024-05-26 (8)

Messages:
2024-05-26 (2)
2024-05-26 (3)

Rationale:

The loading animations should more closely match the content that will eventually replace it. The difference in size between loading and loaded can be slightly strange. Using a "skeleton" design instead of a smaller linear box is a bit more professional in appearance and is what other apps use.

Proposed Changes:

Using the Material UI Skeleton component, refactor the loading animation to more closely match each page's size. For instance, the one for Documents would mimic a grid whereas the one for Profile would mimic both the profile card and grid beneath it.

Try refactoring using the existing LoadingAnimation component rather than creating a completely separate, new one.

Account for #637 if it ends up being added. That animation should remain linear and not a skeleton.

Possible Drawbacks:

This applies primarily for the desktop version. The updated mobile versions have not yet been completed.

Layouts for these pages may yet change (e.g. button placement may shift somewhat). However, the foundations are pretty solidified. The desktop version of Contacts will likely keep the large grid and the desktop version of Profile/Documents will likely keep the card and grid below.

This is a cosmetic change. Not a necessity but a "nice to have".

@andycwilliams andycwilliams added enhancement Enhancement of existing features discovery Open discussion and exploration of topic on hand labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features
Projects
None yet
Development

No branches or pull requests

1 participant