Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] - My Profile>Documents: Document type displayed is not user friendly #669

Closed
kimmykokonut opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kimmykokonut
Copy link

Describe the bug:

The document 'Type' is being displayed in desktop view as the variable, so Bank Statement is being shown as 'bankStatement'.

Expected behavior:

The table holding the list of documents should show the type in a user friendly way.

Actual Behavior:

The type column is showing the key and not the value for the DOC_TYPES object (doc_types.js)

Screenshots:

Screenshot 2024-08-22 at 2 39 31 PM

To Reproduce:

Steps to reproduce the behavior:

  1. Go to 'Profile'
  2. Click on 'Add Document'
  3. Choose document type, expiration date and enter description in the form inputs.
  4. Upload file/photo
  5. Click 'Upload'
  6. Page updates with new document information

Desktop (please complete the following information):

  • OS: Mac
  • Browser Firefox
  • Version 129.0.1 (64-bit)

Possible Fix:

Display the value instead of the key of the doc_types object.

  • It would also be nice to have an 'edit' option as an action, if you want to update the description or expiration date or fix an error.
  • It would be nice to flag docs that are expired as once the doc is uploaded it is difficult to easily see that information.
@kimmykokonut kimmykokonut added the bug Something isn't working label Aug 22, 2024
@joshua-cornett joshua-cornett self-assigned this Aug 26, 2024
@joshua-cornett
Copy link
Contributor

I've resolved this by consequence of working on issue #665.

  • "bankStatement" becomes "Bank Statement.
  • "passport" becomes "Passport"
  • "driversLicense" becomes "Driver's License"
  • etc

@joshua-cornett
Copy link
Contributor

joshua-cornett commented Aug 26, 2024

Actually, I'll mark this closed once my PR for #665 is merged since the pertinent changes won't take affect until then.

@andycwilliams
Copy link
Member

Yes, as a rule we should not be marking issues as completed if the code is still in review and not yet merged. Tying an issue to a pull request should automatically close it upon completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants