Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlying server process is no longer connected to a TTY when launched by gin #137

Open
alexflint opened this issue May 9, 2018 · 0 comments

Comments

@alexflint
Copy link

When running as a gin subprocess, the stdout pipe for the underlying server process is no longer connected to a TTY. This can affect things such as formatting choices made by logging frameworks like logrus.

I'm guessing that the reason for this is that gin is creating a pipe and manually copying things over to the "outer" output stream. If gin instead explicitly transferred ownership of its own stdout and stderr pipes to the subprocess then the subprocess would see them as TTYs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant