Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish example on expo #33

Closed
MBach opened this issue May 22, 2024 · 5 comments · Fixed by #34
Closed

feat: publish example on expo #33

MBach opened this issue May 22, 2024 · 5 comments · Fixed by #34
Labels
enhancement New feature or request

Comments

@MBach
Copy link

MBach commented May 22, 2024

Feature Request

Great package!

I'm starting to play with it, reading the docs, etc. I think the "dev user experience" could be improved by providing a link to expo to quickly see how it's going.

@MBach MBach added the enhancement New feature or request label May 22, 2024
@e-younan
Copy link
Member

Thanks for opening up this issue!

By a link to expo, do you mean an Expo Snack of the example application? If so, I think that since the example application is ejected, it may not be feasible (from what I remember, only Expo Go applications worked in Expo Snacks).

@MBach
Copy link
Author

MBach commented May 23, 2024

Ah OK, that's unfortunate. Expo Snack is quite good to play around.

@MBach
Copy link
Author

MBach commented May 23, 2024

@e-younan
Copy link
Member

Oh, I guess I was wrong! Thanks for creating this - I will add a Snack now. :)

@e-younan e-younan linked a pull request May 24, 2024 that will close this issue
6 tasks
@e-younan
Copy link
Member

Thanks for the suggestion @MBach! This has been merged and released as a new version (0.12.2). You should be able to see the new QR code and link on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants