From 8736e1dedfe0737bf415c69346f0a289fd894486 Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Wed, 23 Nov 2022 13:00:22 -0600 Subject: [PATCH 1/3] chore: fix deps, add some debugging --- bin/goosebay | 2 ++ lib/cli.js | 1 + package-lock.json | 30 +++++++++++++++--------------- package.json | 2 +- 4 files changed, 19 insertions(+), 16 deletions(-) diff --git a/bin/goosebay b/bin/goosebay index 0eed280..535e677 100755 --- a/bin/goosebay +++ b/bin/goosebay @@ -9,6 +9,8 @@ const Cli = require('../lib/cli'); const process = require('process'); const argv = require('minimist')(process.argv.slice(2), Cli.opts); +console.dir({argv}); + // Vector everything to the Cli class const cli = new Cli(); cli.run(argv) diff --git a/lib/cli.js b/lib/cli.js index 157a161..65043e9 100644 --- a/lib/cli.js +++ b/lib/cli.js @@ -28,6 +28,7 @@ class Cli { async run(argv) { const { configName } = argv; + console.dir({configName}); const config = require('./config')({ configName }); diff --git a/package-lock.json b/package-lock.json index 37b6e17..9205951 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "chalk": "^5.0.0", "conf": "^10.1.1", "intuit-oauth": "^4.0.0", - "minimist": "^1.2.5", + "minimist": "^1.2.6", "moment-timezone": "^0.5.34", "node-quickbooks": "^2.0.39" }, @@ -2536,7 +2536,7 @@ "node_modules/jxon": { "version": "2.0.0-beta.5", "resolved": "https://registry.npmjs.org/jxon/-/jxon-2.0.0-beta.5.tgz", - "integrity": "sha1-O2qUEE+YAe5oL9BWZF/1Rz2bND4=", + "integrity": "sha512-Ot7muZ0v2cmgQ1k+e6bpNcz6E3q2zHssvzYubbKTk5nIEvBLqJfiS6/uivU2ujqKZQlORcjKqcyx6D9X6BEAkQ==", "dependencies": { "xmldom": "^0.1.21" } @@ -2807,17 +2807,17 @@ } }, "node_modules/moment": { - "version": "2.29.3", - "resolved": "https://registry.npmjs.org/moment/-/moment-2.29.3.tgz", - "integrity": "sha512-c6YRvhEo//6T2Jz/vVtYzqBzwvPT95JBQ+smCytzf7c50oMZRsR/a4w88aD34I+/QVSfnoAnSBFPJHItlOMJVw==", + "version": "2.29.4", + "resolved": "https://registry.npmjs.org/moment/-/moment-2.29.4.tgz", + "integrity": "sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==", "engines": { "node": "*" } }, "node_modules/moment-timezone": { - "version": "0.5.34", - "resolved": "https://registry.npmjs.org/moment-timezone/-/moment-timezone-0.5.34.tgz", - "integrity": "sha512-3zAEHh2hKUs3EXLESx/wsgw6IQdusOT8Bxm3D9UrHPQR7zlMmzwybC8zHEM1tQ4LJwP7fcxrWr8tuBg05fFCbg==", + "version": "0.5.37", + "resolved": "https://registry.npmjs.org/moment-timezone/-/moment-timezone-0.5.37.tgz", + "integrity": "sha512-uEDzDNFhfaywRl+vwXxffjjq1q0Vzr+fcQpQ1bU0kbzorfS7zVtZnCnGc8mhWmF39d4g4YriF6kwA75mJKE/Zg==", "dependencies": { "moment": ">= 2.9.0" }, @@ -8192,7 +8192,7 @@ "jxon": { "version": "2.0.0-beta.5", "resolved": "https://registry.npmjs.org/jxon/-/jxon-2.0.0-beta.5.tgz", - "integrity": "sha1-O2qUEE+YAe5oL9BWZF/1Rz2bND4=", + "integrity": "sha512-Ot7muZ0v2cmgQ1k+e6bpNcz6E3q2zHssvzYubbKTk5nIEvBLqJfiS6/uivU2ujqKZQlORcjKqcyx6D9X6BEAkQ==", "requires": { "xmldom": "^0.1.21" } @@ -8416,14 +8416,14 @@ "dev": true }, "moment": { - "version": "2.29.3", - "resolved": "https://registry.npmjs.org/moment/-/moment-2.29.3.tgz", - "integrity": "sha512-c6YRvhEo//6T2Jz/vVtYzqBzwvPT95JBQ+smCytzf7c50oMZRsR/a4w88aD34I+/QVSfnoAnSBFPJHItlOMJVw==" + "version": "2.29.4", + "resolved": "https://registry.npmjs.org/moment/-/moment-2.29.4.tgz", + "integrity": "sha512-5LC9SOxjSc2HF6vO2CyuTDNivEdoz2IvyJJGj6X8DJ0eFyfszE0QiEd+iXmBvUP3WHxSjFH/vIsA0EN00cgr8w==" }, "moment-timezone": { - "version": "0.5.34", - "resolved": "https://registry.npmjs.org/moment-timezone/-/moment-timezone-0.5.34.tgz", - "integrity": "sha512-3zAEHh2hKUs3EXLESx/wsgw6IQdusOT8Bxm3D9UrHPQR7zlMmzwybC8zHEM1tQ4LJwP7fcxrWr8tuBg05fFCbg==", + "version": "0.5.37", + "resolved": "https://registry.npmjs.org/moment-timezone/-/moment-timezone-0.5.37.tgz", + "integrity": "sha512-uEDzDNFhfaywRl+vwXxffjjq1q0Vzr+fcQpQ1bU0kbzorfS7zVtZnCnGc8mhWmF39d4g4YriF6kwA75mJKE/Zg==", "requires": { "moment": ">= 2.9.0" } diff --git a/package.json b/package.json index 8b67ca4..2dbcff0 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "chalk": "^5.0.0", "conf": "^10.1.1", "intuit-oauth": "^4.0.0", - "minimist": "^1.2.5", + "minimist": "^1.2.6", "moment-timezone": "^0.5.34", "node-quickbooks": "^2.0.39" }, From 2dcd111bd9226406bef83b5a4ac06c77bff91775 Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Wed, 23 Nov 2022 13:01:14 -0600 Subject: [PATCH 2/3] chore: update deps --- package-lock.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9205951..8772ec6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -2766,9 +2766,9 @@ } }, "node_modules/minimatch": { - "version": "3.0.4", - "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz", - "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==", + "version": "3.1.2", + "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.2.tgz", + "integrity": "sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==", "dev": true, "dependencies": { "brace-expansion": "^1.1.7" @@ -8387,9 +8387,9 @@ "integrity": "sha512-Ysbi9uYW9hFyfrThdDEQuykN4Ey6BuwPD2kpI5ES/nFTDn/98yxYNLZJcgUAKPT/mcrLLKaGzJR9YVxJrIdASQ==" }, "minimatch": { - "version": "3.0.4", - "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz", - "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==", + "version": "3.1.2", + "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.1.2.tgz", + "integrity": "sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==", "dev": true, "requires": { "brace-expansion": "^1.1.7" From cbde55ab350589736359e3f0a4e3465e4b050f79 Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Sat, 20 May 2023 18:45:25 -0500 Subject: [PATCH 3/3] fix: warning instead of crash on untagged interval --- lib/goosebay.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/goosebay.js b/lib/goosebay.js index 09f0e77..5d2ee9f 100644 --- a/lib/goosebay.js +++ b/lib/goosebay.js @@ -554,6 +554,10 @@ class GooseBay { // Log raw data if (VERBOSE) console.dir(n); const { start, end, tags } = n; + if (!tags) { + console.error('No tags- skipping ' + JSON.stringify(n)); + continue; + } const { item_id, item_name, customer_id, customer_name, rate, mainTag } = this.findcode(tags); // findcode will throw