-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CORS Support #28
Comments
I've found that we typically end up setting the CORS headers in our apps, not in a of web proxy, so that we have more dynamic control over how the headers are generated. Adding CORS support in this proxy sounds good, but we'll want it optional behind an environment variable or some other means, since enabling it by default would interfere with testing app-defined CORS functionality. |
I have added a conditional check for a container's e.g.
would enable CORS for |
sweet, sounds great. please add something to the configuration section of the README when you send over the PR, as well. thanks! |
I have added #29 |
I am using
docker-compose
for a web API. I am developing a javascript front-end in a separatedocker-compose
project. I found thatCORS
was not enabled for the API endpoint. In a fork, I have added support forCORS
to thenginx.tmpl
. I am now able to reach the API from the front-end via CORS enabledxhr
request.I have a PR ready if you would like to consider adding
CORS
support.The text was updated successfully, but these errors were encountered: