From b1e5b3f29d63c442f20d1dad1ff72f17d493a8b9 Mon Sep 17 00:00:00 2001
From: daniel_sp <danielsp356@gmail.com>
Date: Mon, 6 Nov 2023 15:06:15 +0000
Subject: [PATCH] enhance admin guardian controller test

---
 .../admin/guardian_controller_test.exs           | 13 +++++--------
 .../controllers/guardian_controller_test.exs     | 16 ++++++++--------
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/test/bokken_web/controllers/admin/guardian_controller_test.exs b/test/bokken_web/controllers/admin/guardian_controller_test.exs
index 82a98ece..65fe20b5 100644
--- a/test/bokken_web/controllers/admin/guardian_controller_test.exs
+++ b/test/bokken_web/controllers/admin/guardian_controller_test.exs
@@ -1,20 +1,15 @@
 defmodule BokkenWeb.Admin.GuardianControllerTest do
   use BokkenWeb.ConnCase
 
-  alias Bokken.Accounts
-
   import Bokken.Factory
 
   setup %{conn: conn} do
-    password = "password1234!"
-    guardian_user = insert(:user, role: "organizer", password: password)
-
-    {:ok, user} = Accounts.authenticate_user(guardian_user.email, password)
-
-    {:ok, conn: log_in_user(conn, user)}
+    {:ok, conn: put_resp_header(conn, "accept", "application/json")}
   end
 
   describe "index" do
+    setup [:login_as_organizer]
+
     test "lists all guardians", %{conn: conn} do
       conn = get(conn, ~p"/api/admin/guardians/")
       assert json_response(conn, 200)["data"] == []
@@ -22,6 +17,8 @@ defmodule BokkenWeb.Admin.GuardianControllerTest do
   end
 
   describe "show" do
+    setup [:login_as_organizer]
+
     test "shoes", %{conn: conn} do
       guardian = insert(:guardian)
 
diff --git a/test/bokken_web/controllers/guardian_controller_test.exs b/test/bokken_web/controllers/guardian_controller_test.exs
index 901ea576..3cc73545 100644
--- a/test/bokken_web/controllers/guardian_controller_test.exs
+++ b/test/bokken_web/controllers/guardian_controller_test.exs
@@ -1,28 +1,26 @@
 defmodule BokkenWeb.GuardianControllerTest do
   use BokkenWeb.ConnCase
 
-  alias Bokken.Accounts
   alias Bokken.Accounts.Guardian
 
   import Bokken.Factory
 
   setup %{conn: conn} do
-    password = "password1234!"
-    guardian_user = insert(:user, role: "guardian", password: password)
-
-    {:ok, user} = Accounts.authenticate_user(guardian_user.email, password)
-
-    {:ok, conn: log_in_user(conn, user)}
+    {:ok, conn: put_resp_header(conn, "accept", "application/json")}
   end
 
   describe "index" do
+    setup [:login_as_guardian]
+
     test "lists all guardians", %{conn: conn} do
       conn = get(conn, ~p"/api/guardians/")
-      assert json_response(conn, 200)["data"] == []
+      assert json_response(conn, 200)["data"] != []
     end
   end
 
   describe "create guardian" do
+    setup [:login_as_guardian]
+
     test "renders guardian when data is valid", %{conn: conn} do
       new_user = insert(:user, role: "guardian")
 
@@ -62,6 +60,7 @@ defmodule BokkenWeb.GuardianControllerTest do
   end
 
   describe "update guardian" do
+    setup [:login_as_guardian]
     setup [:new_guardian_update]
 
     test "renders guardian when data is valid", %{
@@ -98,6 +97,7 @@ defmodule BokkenWeb.GuardianControllerTest do
   end
 
   describe "delete guardian" do
+    setup [:login_as_guardian]
     setup [:new_guardian]
 
     test "deletes chosen guardian", %{conn: conn, guardian: guardian} do