Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curated Tag List for Styles #376

Open
thenewguy opened this issue Nov 9, 2020 · 3 comments
Open

Curated Tag List for Styles #376

thenewguy opened this issue Nov 9, 2020 · 3 comments
Labels
Type: Enhancement New feature or functionality change

Comments

@thenewguy
Copy link
Contributor

It would be helpful if the tags input was a curated tag list. Could be controlled with django taggit and a snippet model. Ideally preloaded with bootstrap style classes

@thenewguy thenewguy added the Type: Enhancement New feature or functionality change label Nov 9, 2020
@thenewguy thenewguy changed the title Curated Tag List for Stles Curated Tag List for Styles Nov 10, 2020
@vsalvino
Copy link
Contributor

This is a good idea, but would be really difficult to implement. You'd have to somehow parse all of the site's CSS, most likely as part of the deployment process, to determine which CSS class names are available to be suggested in the field. I don't think it would be practical to implement, but many people have brought it up as an idea.

I think a better approach would be to move away from relying on custom CSS classes, and add fields for common properties such as alignment, color, position, etc. And to improve the custom template experience for developers.

@thenewguy
Copy link
Contributor Author

thenewguy commented Nov 10, 2020

It would be up to the editors to add the tags for "custom" css. They would be addable from the snippet model.

Like this: https://docs.wagtail.io/en/v2.11.1/reference/pages/model_recipes.html?highlight=tag#disabling-free-tagging

What I meant for the "default" would be bootstrap's default tags. Like text-center, m-3, p-3, etc that are common among all bootstrap sites

-- Edit --

The benefit would be documenting available tags and also autocomplete from the tag widget

@thenewguy
Copy link
Contributor Author

I agree it would be nice to have some clicky options for common things on certain blocks - like centered text - but the custom css classes is pretty powerful. I would hate to see it go as it would take a tremendous number of clickies to replace all of the options. This handles a nice catch-all for those few blocks that need to be different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or functionality change
Projects
None yet
Development

No branches or pull requests

2 participants