Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-vendor wagtail_flexible_forms #430

Open
1 of 5 tasks
vsalvino opened this issue Aug 2, 2021 · 8 comments
Open
1 of 5 tasks

De-vendor wagtail_flexible_forms #430

vsalvino opened this issue Aug 2, 2021 · 8 comments
Labels
Area: Vendor Type: Enhancement New feature or functionality change Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future.

Comments

@vsalvino
Copy link
Contributor

vsalvino commented Aug 2, 2021

Currently we have vendored wagtail_flexible_forms by @BertrandBordage in order to provide support and integration within CodeRed CMS.

This is fine, however it is an ideal candidate to be split out into a separate pip package. This would be relatively trivial because it is already namespaced within coderedcms. The advantage here is that other wagtail sites could use it, and it could be an optional part of coderedcms.

While I wouldn't want to step on Bertrand's toes by taking over the project, we would have to fork and take over it in order to provide a pip package. Since a pip package was never created that would not technically be a problem.

If anyone has any input, please speak now!

Requirements:

  • Create separate wagtail_flexible_forms repository (While I would normally want to provide a fork, the code would then not be searchable on github, etc., and the original does not seem to be maintained).
  • Create at a minimum basic unit tests, ideally 60-70% coverage to ensure there is no major breakage.
  • Document the package extensively. Currently there is no documentation.
  • Publish a pip package
  • Remove the code in coderedcms, and integrate the new package.
@vsalvino vsalvino added Type: Enhancement New feature or functionality change Area: Vendor labels Aug 2, 2021
@BertrandBordage
Copy link

Feel free to take over wagtail_flexible_forms if you want :)
I can transfer the ownership of the repository to coderedcorp and same for the PyPI package.

@vsalvino
Copy link
Contributor Author

vsalvino commented Aug 2, 2021

@BertrandBordage that would be helpful. I know some users have commented that they are using coderedcms purely for the flexible form support, so that is something we plan on actively maintaining.

I deleted our fork, so can you please transfer to repository to our coderedcorp organization on github? The pypi package would be under owner codered (we also have coderedcorp squatted but publish everything under codered); although I wasn't even aware there was a pypi package!

@vsalvino vsalvino added the Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future. label Aug 2, 2021
@BertrandBordage
Copy link

Ah, I need to get a temporary access to create public repositories in your organisation:
image

In fact there is no PyPI package for it, so please register it right now :)

@BertrandBordage
Copy link

I accepted the invitation, but I'm still getting the same error :\

@vsalvino
Copy link
Contributor Author

vsalvino commented Aug 2, 2021

@BertrandBordage I think it was related to some permissions. Can you give it a try now?

@BertrandBordage
Copy link

Done! You can remove me from the organization now!

@vsalvino
Copy link
Contributor Author

vsalvino commented Aug 3, 2021

Received, thank you. I added you as a contributor to that specific repo, so feel free to continue development if you get the itch :)

@vsalvino vsalvino added this to the 0.22.0 milestone Aug 3, 2021
@vsalvino vsalvino modified the milestones: 0.22.0, 0.23.0 Sep 9, 2021
@vsalvino vsalvino removed this from the 0.23.0 milestone Jan 14, 2022
@dwasyl
Copy link

dwasyl commented Oct 3, 2022

Has there been any behind the scenes progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Vendor Type: Enhancement New feature or functionality change Type: Tech Debt Use this label for decisions that will intentionally require refactor in the future.
Projects
None yet
Development

No branches or pull requests

3 participants