Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible typo in coderedcms.forms #628

Open
ElectronicRU opened this issue Mar 7, 2024 · 3 comments · May be fixed by #645
Open

Possible typo in coderedcms.forms #628

ElectronicRU opened this issue Mar 7, 2024 · 3 comments · May be fixed by #645
Labels
Type: Bug Something isn't working

Comments

@ElectronicRU
Copy link

https://github.com/coderedcorp/coderedcms/blob/main/coderedcms/forms.py#L187

Shouldn't the 'default' here be 'singleline' instead of the untranslated help string?
@ElectronicRU ElectronicRU added the Type: Bug Something isn't working label Mar 7, 2024
@vsalvino
Copy link
Contributor

vsalvino commented Mar 7, 2024

I think you are correct. If you can make a test a fix, I'd be happy to merge it. Thanks!

@ElectronicRU
Copy link
Author

Not sure how to write a DRY test for this. Does this need a testcase?

@vsalvino
Copy link
Contributor

Don't need a test for that, it is a small enough fix. Thanks!

ElectronicRU added a commit to ElectronicRU/coderedcms that referenced this issue Jun 16, 2024
@ElectronicRU
Fix default field type in forms
4c9471d 
Fixes coderedcorp#628
@ElectronicRU ElectronicRU linked a pull request Jun 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default field type in forms ElectronicRU/coderedcms
2 participants
@ElectronicRU @vsalvino