Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded data filename #16

Open
yevgenybulochnik opened this issue May 12, 2020 · 3 comments
Open

Remove hardcoded data filename #16

yevgenybulochnik opened this issue May 12, 2020 · 3 comments
Assignees
@hl1
Labels
enhancement New feature or request

Comments

@yevgenybulochnik
Copy link
Member

yevgenybulochnik commented May 12, 2020 •
edited
Loading

Currently to load data into the database a file must be present in data/. This file name is currently hardcoded. I would suggest we come up with a solution to remove this dependency. This issue is likely dependent on #15
@yevgenybulochnik yevgenybulochnik added the enhancement New feature or request label May 12, 2020
@finish06
Copy link
Member

I think a step further would be to scrap the OpenFDA website and pull the zip file. Then we know we are working with the most up to date data.

@yevgenybulochnik
Copy link
Member Author

@hl1 do you want to take a crack at this once we figure out #15

@hl1
Copy link
Contributor

hl1 commented May 23, 2020

@yevgenybulochnik I will take care of this.. keep it open for now. I need this to go to master first: #18

@hl1 hl1 self-assigned this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hl1 hl1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@finish06 @yevgenybulochnik @hl1