From 09972e313984e2bda22be7d67bae25fa13fa3be2 Mon Sep 17 00:00:00 2001 From: Tobias Neitzel Date: Tue, 14 Nov 2023 21:29:12 +0100 Subject: [PATCH 1/3] Fix incorrect check whether vault is running The check that should ensure that the vault qube is running instead checked whether the qube exists. This was fixed in this commit. --- qubes-keepass-dom0.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qubes-keepass-dom0.sh b/qubes-keepass-dom0.sh index f628d4e..e781b57 100755 --- a/qubes-keepass-dom0.sh +++ b/qubes-keepass-dom0.sh @@ -63,7 +63,7 @@ function main() { set -e set -x - qvm-check "${VAULT}" + qvm-check --running -q "${VAULT}" if [ $? -ne 0 ]; then echo "[-] Your vault qube ${VAULT} is not running yet." From a91c42f1d2b0406beec580242f48e4324aa95d79 Mon Sep 17 00:00:00 2001 From: Tobias Neitzel Date: Thu, 16 Nov 2023 09:47:00 +0100 Subject: [PATCH 2/3] Fix typos in legacy policy format --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6eae4e5..c2a6a46 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ Qube to copy credentials to other *AppVMs*: ```console [user@dom0 ~]$ cat /etc/qubes-rpc/policy/custom.QubesKeepass -vault $anyvm allow notify=true +vault @anyvm allow notify=yes ``` According to your preferences, you could also choose `ask` instead of the `allow` action or remove the `notify=true` option, From 42ed499d13e2c221230cf24f31d3c54a0f292ee0 Mon Sep 17 00:00:00 2001 From: Tobias Neitzel Date: Fri, 17 Nov 2023 12:23:17 +0100 Subject: [PATCH 3/3] Bump version number --- CHANGELOG.md | 8 ++++++++ qubes-keepass-dom0.sh | 1 + qubes-keepass.py | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eaa53d4..af9454e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## v1.2.0 - Nov 17, 2023 + +### Changed + +* qubes-keepass-dom0 now aborts if the vault qube is not running +* Minor bugfixes + + ## v1.1.0 - May 31, 2023 ### Added diff --git a/qubes-keepass-dom0.sh b/qubes-keepass-dom0.sh index e781b57..7a0f2c7 100755 --- a/qubes-keepass-dom0.sh +++ b/qubes-keepass-dom0.sh @@ -2,6 +2,7 @@ VAULT='vault' +VERSION='qubes-keepass v1.2.0' function get_id() { diff --git a/qubes-keepass.py b/qubes-keepass.py index f061205..a6ac156 100755 --- a/qubes-keepass.py +++ b/qubes-keepass.py @@ -838,7 +838,7 @@ def load(service: Secret.Service) -> CredentialCollection: return CredentialCollection(credentials) -parser = argparse.ArgumentParser(description='''qubes-keepass v1.1.0 - A rofi based KeePassXC frontend for Qubes''') +parser = argparse.ArgumentParser(description='''qubes-keepass v1.2.0 - A rofi based KeePassXC frontend for Qubes''') parser.add_argument('qube', help='qube to copy the credential to') parser.add_argument('--trust-level', type=int, help='numerical trust level of the qube') parser.add_argument('--config', help='path to the configuration file')