Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestStorage input validation #106

Open
Tracked by #49
AuHau opened this issue May 22, 2024 · 0 comments · May be fixed by #213
Open
Tracked by #49

requestStorage input validation #106

AuHau opened this issue May 22, 2024 · 0 comments · May be fixed by #213
Assignees
@2-towns
Labels
Bug Something isn't working Certora Issues discovered as part of Certora integration Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@AuHau
Copy link
Member

AuHau commented May 22, 2024

codex-contracts-eth/contracts/Marketplace.sol

Line 89 in 57e8cd5

function requestStorage(Request calldata request) public {

We should do some validation on the inputted Request, mainly that all the values are specified (non-zero) and possibly some more.
@AuHau AuHau added Bug Something isn't working Certora Issues discovered as part of Certora integration labels May 22, 2024
@emizzle emizzle mentioned this issue Jun 12, 2024
Open
5 tasks
@gmega gmega added the Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details label Sep 18, 2024
@2-towns 2-towns linked a pull request Jan 15, 2025 that will close this issue
Open
@2-towns 2-towns self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2-towns 2-towns

Labels
Bug Something isn't working Certora Issues discovered as part of Certora integration Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add request validations codex-storage/codex-contracts-eth
3 participants
@gmega @AuHau @2-towns