Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof submission from other address? #151

Open
AuHau opened this issue Aug 13, 2024 · 2 comments
Open

Proof submission from other address? #151

AuHau opened this issue Aug 13, 2024 · 2 comments
Labels
Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@AuHau
Copy link
Member

AuHau commented Aug 13, 2024

While writing the spec, I realized that we do not check the address of the tx sender for submitting proof.
Should we restrict that? While I don't necessarily see any problems with leaving it open, my intuition says we should restrict it. Restricting also does not affect anything IMHO, but may prevent some potential issues?

@markspanbroek
Copy link
Member

I don't know. I left it open, because I didn't want to restrict scenarios where the sending of the transaction is outsourced to some other party. An aggregator could be the other party later on. But then we'll end up changing submitProof() anyway.
And maybe we don't want hosts to outsource this stuff...

@AuHau
Copy link
Member Author

AuHau commented Aug 13, 2024

Yeah, my exact thoughts are that we should not allow outsourcing...

I would restrict it for now and revisit it if needed.

@AuHau AuHau added the Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Development

No branches or pull requests

2 participants