Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests proof is required after downtime has failed #153

Open
0x-r4bbit opened this issue Aug 13, 2024 · 0 comments
Open

Tests proof is required after downtime has failed #153

0x-r4bbit opened this issue Aug 13, 2024 · 0 comments

Comments

@0x-r4bbit
Copy link
Collaborator

Without changes to the contract, one of the tests have failed on CI:

https://github.com/codex-storage/codex-contracts-eth/actions/runs/10369570159/job/28705585253?pr=152

The output:

93 passing (52s)
  1 failing

  1) Proofs
       when proof requirement is upcoming
         means that a proof is required after downtime:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (test/Proofs.test.js:[150](https://github.com/codex-storage/codex-contracts-eth/actions/runs/10369570159/job/28705585253?pr=152#step:5:151):57)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at runNextTicks (node:internal/process/task_queues:64:3)
      at listOnTimeout (node:internal/timers:538:9)
      at processTimers (node:internal/timers:512:7)

Unfortunately we cannot see what values have been used in the test, so it's unclear what parameters caused the failure.
In any case, something worth investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant