Add public function that retrieves RequestContext for a Request

[emizzle]

A public view function that retrieves the RequestContext of a StorageRequest should be added to the Marketplace contract. It will replace a few other view functions currently exposed, and add more information. This will allow the Codex client to expose this information in the REST API.

The following fields should be exposed from the RequestContext struct:

• state
• slotsFilled
• startedAt
• endsAt

This view function will replace the following functions:

• requestEnd
• requestState
• requestExpiry

[emizzle]

@2-towns from our discussion at the offsite 👍

[2-towns]

The current functions requestEnd, requestState and requestExpiry are containing some business logic. Here is an example:

  function requestState(
    RequestId requestId
  ) public view requestIsKnown(requestId) returns (RequestState) {
    RequestContext storage context = _requestContexts[requestId];
    if (
      context.state == RequestState.New &&
      block.timestamp > requestExpiry(requestId)
    ) {
      return RequestState.Cancelled;
    } else if (
      (context.state == RequestState.Started ||
        context.state == RequestState.New) && block.timestamp > context.endsAt
    ) {
      return RequestState.Finished;
    } else {
      return context.state;
    }
  }

So when you say that the new view will replace these functions, it should include that business logic right ?

[emizzle]

Notes from discussion:
Public view requestContext would call requestState, requestEnd, requestExpiry (which will be made private)

Ice for now as lower priority

[2-towns]

Notes from discussion:
Public view requestContext would call requestState, requestEnd, requestExpiry (which will be made private)

Yes, and since those three methods can be called internally by the contract itself, it is better to keep them separate to avoid extra calculations and save gas costs.