Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding cleanup items #1054

Open
AuHau opened this issue Dec 30, 2024 · 0 comments
Open

Outstanding cleanup items #1054

AuHau opened this issue Dec 30, 2024 · 0 comments

Comments

@AuHau
Copy link
Member

AuHau commented Dec 30, 2024

In my cleanup work I mainly focused on removing unused imports, but there are 3 other types of issues that should get cleanuped:

Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/manifest/coders.nim(266, 16) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/blockexchange/discovery/testdiscovery.nim(111, 25) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/streams/storestream.nim(107, 74) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/erasure/erasure.nim(221, 19) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/erasure/erasure.nim(221, 19) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/node.nim(546, 27) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/codex/node.nim(546, 27) Warning: use treeCid instead; cid is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/vendor/nim-chronicles/chronicles/scope_helpers.nim(10, 18) Warning: use treeCid instead; cid is deprecated [Deprecated]
General
/Users/adam/Projects/status/nim-codex/codex/conf.nim(676, 7) Warning: Please use MetricsHttpServerRef API; startMetricsHttpServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(11, 13) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(14, 13) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/helpers/trackers.nim(18, 17) Warning: Please use getTrackerCounter() instead; getTracker is deprecated [Deprecated]
Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/randomchunker.nim(28, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/testchunking.nim(24, 5) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/codex/chunker.nim(85, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/codex/chunker.nim(118, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/helpers/mockchunker.nim(23, 3) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(36, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(55, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
/Users/adam/Projects/status/nim-codex/tests/codex/testasyncstreamwrapper.nim(76, 18) Warning: Callback must not raise exceptions, annotate with {.async: (raises: []).}; createStreamServer is deprecated [Deprecated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant