Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to nim-poseidon2-bn254 #23

Open
bkomuves opened this issue Jan 17, 2025 · 0 comments
Open

Rename to nim-poseidon2-bn254 #23

bkomuves opened this issue Jan 17, 2025 · 0 comments

Comments

@bkomuves
Copy link
Contributor

As we are now dealing with different fields and different hash functions, in particular we have poseidon2 version(s) which are different from this one, I would prefer to rename this to nim-poseidon2-bn254 to signify that this one is over the BN254 curve's scalar field.

I don't want to put all of them into the same package, because this was has a very heavy dependency (constantine), while the other one is self-contained.

Not sure how painful is the renaming process in practice, or how to organize / synchronize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant