Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow duplicate claims #275

Closed
prabalsingh24 opened this issue May 18, 2020 · 7 comments
Closed

Don't allow duplicate claims #275

prabalsingh24 opened this issue May 18, 2020 · 7 comments

Comments

@prabalsingh24
Copy link
Contributor

prabalsingh24 commented May 18, 2020

Kind of an extension of #260

There might be cases when a student add a same claim twice. And if the mentor accepts the both of them, it will give student double bounty. There should be feature to avoid having duplicate claims

@hereisnaman This can be a different issue right? Because this feature is slightly different than conflicting claims one

@ankiiitraj
Copy link
Contributor

Hi @prabalsingh24 , sometimes mentors allow both the persons who made PR for the same isuue to claim points. So I think there can be another solution for this.

@prabalsingh24
Copy link
Contributor Author

No that is a conflicting issue (Both of them have same issue but different PRs) . I am talking about duplicates (Same username, same issue, same pr)

@prabalsingh24
Copy link
Contributor Author

Edit: This is a already a feature. but It is not working for the cases when different type of URL is used (/ in the end, http-->https),

@ankiiitraj
Copy link
Contributor

Gotcha @prabalsingh24

@thenamankumar
Copy link
Contributor

You can work on it.

@ankiiitraj
Copy link
Contributor

This work feature is already present. I tried adding two claims with same pull url and I got error page saying I have taken that already.

@prabalsingh24
Copy link
Contributor Author

This work feature is already present. I tried adding two claims with same pull url and I got error page saying I have taken that already.
Check my previous comment
#275 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants