-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sci-kit learn neural networks #5
Comments
At the moment with ONNX we can support keras, tensorflow, and pytorch. Scikit has an ONNX exporter but I'm not sure how it works with neural networks. |
@jalving do you still have interest in this? I saw there’s a package sklearn2onnx so I could work on building this out. Alternatively since the package exists we could just have the user do the conversion? |
I think we should at least test out the converter and make sure that onnx model imports into OMLT. I think we should also add links to the ONNX converters for various ML platforms. Once we do that, we should discuss a direct interface to sci-kt learn. It's another interface to support, but it might be worthwhile. |
I was curious so I messed around a bit with it today in between classes. I also wrote some code to convert sklearn scalers into OMLT scaling objects. It’s on my fork here https://github.com/joshuahaddad/OMLT/blob/sklearn-reader/src/omlt/io/sklearn-reader.py. We should definitely talk about the specifics of the interface. I’d be interested in seeing some of the sklearn models Carl had if they’re not proprietary. |
This is pretty cool. Going through ONNX is a good way to support sklearn models. I have a sklearn model that is not proprietary. I will send it your way. |
Is there interest in adding other readers in addition to ONNX? I have a working sci-kit learn neural network reader.
The text was updated successfully, but these errors were encountered: