Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type for driver_version #8

Open
GabrielMajeri opened this issue Jun 22, 2018 · 3 comments
Open

Wrong return type for driver_version #8

GabrielMajeri opened this issue Jun 22, 2018 · 3 comments

Comments

@GabrielMajeri
Copy link
Contributor

The driver_version function returns a voodoo::Version structure.

However, the spec does not say if this is in the same format as a Vulkan version. It's just a u32, its format is driver-specific.

@c0gent
Copy link
Member

c0gent commented Jun 22, 2018

Version is convertible to and from a u32 (the Vulkan native format). The format should not be driver specific. If it is, it's a bug. Can you give an example and provide your hardware/driver specifications?

@GabrielMajeri
Copy link
Contributor Author

The Vulkan GPUInfo site contains a function to convert from that device specific format to a more readable one.

For example, NVIDIA packs 4 numbers in the u32, Intel on Windows packs 2 numbers (a major and a minor version), and Mesa seems to indeed use the Vulkan version format.

@c0gent
Copy link
Member

c0gent commented Jun 22, 2018

I see what you mean. You're right, that API isn't correct.

Could you submit a fix for it? I'm not going to have time to work on it right away.

Thanks for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants