Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v6.4 #6

Open
Auronmatrix opened this issue Mar 8, 2012 · 14 comments
Open

Support for v6.4 #6

Auronmatrix opened this issue Mar 8, 2012 · 14 comments

Comments

@Auronmatrix
Copy link

HI,

Downloaded newest version and tried installing on Sugar 6.4 CE. When uploading the module I get the following error:

ZIP Error(0): Status(0): Arhive(upload://cognitom.zip): Directory(/tmp/6nld1n)

I also changed the manifest.php to include v6.4.1 specifically, with no luck. Same error except sometimes it only gives the ZIP Error(0): Status(0) error code.

Is there support for the SugarCRM 6.4.1 Community Edition? Is this error related to the module installation or Sugar?

Thanks for the incredible work, and keep it up!

@ernierasta ernierasta reopened this Mar 8, 2012
@ernierasta
Copy link
Contributor

Hmm. not sure to be honest. I've not tested it on latest SugarCRM, but it should work. Your problem looks like to be related to installation process, no to theme itself. Give mi a hour and will test it on clean latest release (i am also curious ;-) ).

@Auronmatrix
Copy link
Author

Okay great thanks!

@ernierasta
Copy link
Contributor

Ok, one thing is sure. I can not work like that! Look at zip file you downloaded from here. There is subdirectory in it. You have to unpack it and make new zip file from content of cognitom-ModernAqua-Theme-for-SugarCRM-BLAHBLAH.

But anyway, for me, Module Loader is broken in 6.4.x. I have never managed install any extension, but probably it is only in my setup. But if I copied manually directory ModernAqua to themes directory it works ok.

I see some glitches in 6.4.1 - calendar is not well themed etc. They are also in 6.3, but I made some workaround that it works well in 6.3.x. But I know that there must better solution (it is all about black/white backgroud). So I am not going to fix it for 6.4 now, because it is just making another workarounds - and it would be bad. I will have to manage how to detect Home called from Ajax well (from css point of view) and it will solve most of issues.

As I am not webdeveloper, nor web designer (I just made dirty hacks to let ModerAqua work with latest SugarCRM releases) i will later look for someone who could fix issues better than me.

EDIT: I finally found solution to broken Module Loader! You have to edit: ModuleInstall/PackageManager/PackageManager.php:
on row 668 add:$upgrade_content = str_replace ("upload://","upload/",$upgrade_content);. So it should be:
if(empty($md5_matches))
{
$upgrade_content = str_replace ("upload://","upload/",$upgrade_content);
$target_manifest = remove_file_extension( $upgrade_content ) . '-manifest.php';
require_once($target_manifest);

That allows me to move to 6.5 version (when stable) so ModernAqua should support it. ;-)

@Auronmatrix
Copy link
Author

Thanks ernierasta! I will try looking at copying it directly to the themes directory!

Regards

Auron

@dauclair
Copy link

@Auronspan ernierasta is correct about the ZIP Error(0) problem. The error occurs when you upload a zip file that contains a top-level directory. You must download the zip file from github, then extract it to your computer. Open the extracted folder and re-zip only the contents (manifest.php file, /images/ folder and /ModernAqua/ folder). Try the Module Loader again and it should work this time.

@ernierasta I noticed the minor glitches in the Calendar background color. Since the calendar table is gray and the #content div is dark gray, it is difficult to read the calendar. If anyone needs to fix this, my workaround was to search the /themes/ModernAqua/css/style.css file and comment out the "background:none;" css property. You will find it in two places, one for main calendar and one for shared calendar. Just search the file for "div#content" and you will easily find it.

This is such a great SugarCRM theme, thanks to everyone who has contributed to it, I hope my comments help!

@ernierasta
Copy link
Contributor

@dauclair You are right, but I think problem is deeper.
We have wrong default background color - and yes i made it to be wrong ;-). But main problem from my point of view is here(yui.css) - it should not be there (background defs):
body#Home.ajaxui div#content {
background: none repeat scroll 0 0 transparent;
padding: 0px;
}

body#Home.yui-skin-sam div#content {
background: none repeat scroll 0 0 transparent;
border: 0 none;
margin: 40px 0 10px 213px;
padding: 0px;
}

I think we should have white background by default and dark should be defined explicitly. But maybe I am wrong with it. In previous versions of ModernAqua white was default, and it was better because of custom modules. White is mostly better there. I changed it because of Home page called from Ajax (and few other places) were ugly white.
Because of Ajax i am unable to get unique css paths now - look at:
Home page: html.yui3-js-enabled body#Home.yui-skin-sam div#main div#content
Contacts: html.yui3-js-enabled body#Home.yui-skin-sam div#main div#content

But i am sure - it is fixable (here it is lack of my knowledge and experiences in this field) - it will be very useful if we can get unique css path for every module called by Ajax (maybe we should modify template - add additional div with module name which came from where? some js function?).

In case of Calendar - it is not Ajax call so it is fixable easily and your way is ok (i will test is it is backward compatible and if so i will push changes here).

@dauclair
Copy link

Hi @ernierasta, thanks for the update. I did not dig in very deep, but in my case the following worked in Sugar CE 6.4.1, tested in Google Chrome 17 on Mac OSX:

  • I commented out the background:none; property in style.css near line 1979 (body#Calendar div#content)
  • This allows #F5F5F5 background property in style.css near line 531 to apply again (div#content, body#Currencies.index div#content)

However, like you said, this is only a workaround and not a long term solution. A unique css selector for each module sounds like it would be helpful. I have only begun looking at the code today, so I will definitely spend some more time comparing the ajaxui/non ajaxui css selectors and the possibility of modifying the template so that I can better follow your thought process. I will report back to you if I can find anything that may help.

@basilabbassv
Copy link

Great work guys.

After installing the theme only the login screen has changed. Everything else has remained the same. My version is 6.4.5.

@ernierasta
Copy link
Contributor

Hi, change default theme (in Sugar user properties) for your user, and you are good to go ;-). But as mentioned before - for now theme works the best with 6.3.x.

@basilabbassv
Copy link

Hello Cimala,

I did change the default theme as well and also cleared the cache. Nothing seems to have changed. Only once the cache is cleared the new login screen appears. After login the login screen reverts back to the old screen.

Regards.

Basil Abbas
Co-Founder
TECSOL Software Pvt. Ltd.

#51 | 3rd Floor | 6th Main, 14 th Cross, BTM 2nd Stage | Bangalore 5600 76 | Karnataka | India.
T: +91 80 4150 8434 | M: +91 9886 432 663 | E: [email protected] (mailto:[email protected]) | W: http:///www.tecsolsoftware.com (http://www.tecsolsoftware.com/)

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.

Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Sunday, 29 July 2012 at 6:57 PM, Leszek Cimala wrote:

Hi, change default theme (in Sugar user properties) for your user, and you are good to go ;-). But as mentioned before - for now theme works the best with 6.3.x.


Reply to this email directly or view it on GitHub:
#6 (comment)

@DarkStar1
Copy link

I am new to sugar and I'm currrently trying to apply the modern Aqua theme to 6.5.0 and 6.5.2. I have made some changes to the manifest and themedef.php files but I get the strangest behaviour which leads me to believe that 6.5.X line has caught the proverbial flu. On the login page I get a partially applied theme, I say partially applied because the layout and colour is there but it applies changes I made to the login box of the default theme after which when I login it reverts back to the default interface. This only happens shortly after bootup of the machine on which this test instance is running. After that logging out reverts back to the normal default. Has anyone experienced this odd behaviour?

@basilabbassv
Copy link

Yes I am having the exact same issue. I was not able to fix it.

Sent from my iPad

On 21-Aug-2012, at 7:36 PM, DarkStar1 [email protected] wrote:

I am new to sugar and I'm currrently trying to apply the modern Aqua theme
to 6.5.0 and 6.5.2. I have made some changes to the manifest and
themedef.php files but I get the strangest behaviour which leads me to
believe that 6.5.X line has caught the proverbial flu. On the login page I
get a partially applied theme, I say partially applied because the layout
and colour is there but it applies changes I made to the login box of the
default theme after which when I login it reverts back to the default
interface. This only happens shortly after bootup of the machine on which
this test instance is running. After that logging out reverts back to the
normal default. Has anyone experienced this odd behaviour?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/6#issuecomment-7901932.

@DarkStar1
Copy link

@basilabbassv New discovery. I wanted to install the aqua theme as a reference guide to creating my own theme, so I went ahead and started trying to create my own theme when I noticed that in order to make visual layout changes to the login page I had to modify the sugar5 theme in the theme directory, where as the documentation says that one need only copy the default into the custom/Themes directory and not specify the parentTheme attribute in the Themedef file. I can only imagine that there has been changes made to the theme framework and the documentation is wrong somewhat.

@ssyuzev
Copy link

ssyuzev commented Dec 20, 2013

Hello! Tell me please why Convert Lead Button not Present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants