Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show positive and negative counts for each mutation #161

Open
dhimmel opened this issue Mar 5, 2018 · 5 comments
Open

Show positive and negative counts for each mutation #161

dhimmel opened this issue Mar 5, 2018 · 5 comments

Comments

@dhimmel
Copy link
Member

dhimmel commented Mar 5, 2018

It'd be useful to know how many samples were mutated (positives) and not mutated (negatives) for each gene selected by the user. It'd even be even slicker if you could see these counts in the search menu even before adding a gene (but that may be computationally infeasible). These values would add up to the total number of samples for all the selected diseases.

Is this feasible with the current architecture?

@dhimmel
Copy link
Member Author

dhimmel commented Mar 5, 2018

In the search table for genes, the positive and negative counts could replace the SCORE column. Even if we don't add positives/negatives, we should consider removing score. Score is the search ranking by mygene.info. It may be helpful for diagnosis but is likely to confuse users (it's not a score relevant to cancer or anything like that)

@cgreene
Copy link
Member

cgreene commented Mar 5, 2018

If we sort by SCORE, would that improve our ability to place the most relevant gene at the top of the list? I notice that we're not particularly good at that via the alphabetical ordering scheme.

@dhimmel
Copy link
Member Author

dhimmel commented Mar 5, 2018

The table should definitely be sorted by SCORE descending (that is the point of score). However, the user doesn't need to see.

Also there's definitely a problem with the search configuration... For example, BRCA returns no results. Let's deal with that in a separate issue.

@ramenhog ramenhog reopened this Mar 14, 2018
@ramenhog
Copy link
Collaborator

Showing pos and neg counts is definitely possible with the frontend architecture, but it doesn't seem like we have an endpoint for getting the positives count for each gene. If we can add that into the backend, it shouldn't be too tough to do via the frontend.

But I can definitely get rid of the SCORE column. But do we want the gene results sorted by SCORE initially until the user clicks on another column to sort by that column? Then how will they get back to sorting via SCORE?

@dhimmel
Copy link
Member Author

dhimmel commented Mar 14, 2018

the user clicks on another column to sort by that column

I don't think the chart needs to be sortable beyond score. That'd kinda be like saying I want to sort Google Autocomplete alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants