Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple CdGpt getAnalysisContent method from entryAnalysisSchema model methods. #173

Open
hiyaryan opened this issue Oct 4, 2024 · 1 comment
Assignees
Labels
dev Related to development refactor Code refactoring todo Related to dev TODO comments in source

Comments

@hiyaryan
Copy link
Member

hiyaryan commented Oct 4, 2024

Accomplish TODO below from commit in backend/src/models/entry/entryAnalysis.ts of #169 and remove ESLint disable comments.

Line: 58
Message: // TODO: pull out this method to somewhere else. dependency on CdGpt not great
Commit: 6007601

@hiyaryan hiyaryan added dev Related to development todo Related to dev TODO comments in source refactor Code refactoring labels Oct 4, 2024
@davidzlu
Copy link
Collaborator

EntryServcies._updateEntry would need to be updated as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Related to development refactor Code refactoring todo Related to dev TODO comments in source
Projects
None yet
Development

No branches or pull requests

2 participants