Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize providers for PostgreSQL and Oracle to separate jars #20

Open
cardil opened this issue Jun 26, 2018 · 4 comments
Open

Externalize providers for PostgreSQL and Oracle to separate jars #20

cardil opened this issue Jun 26, 2018 · 4 comments

Comments

@cardil
Copy link
Collaborator

cardil commented Jun 26, 2018

Code for database providers (that uses native jdbc to create databases) should be externalized to separate jars. That's because those jars should became OSGi plugins in future.

Mind you that Cascades own persistence (Hibernate+PostgreSQL) shouldn't be moved. It's two separate things.

@speedlog
Copy link
Member

I propose to do this when every feature (create template, delete template, create database instance, delete database instance) will work.

@cardil
Copy link
Collaborator Author

cardil commented Jun 26, 2018

You can externalize providers without making OSGI modules. Just create some Maven submodules and add dependencies.

In that way you will have good separation from start and it will be easier to refactor in future.

@speedlog speedlog reopened this Jun 26, 2018
@cardil
Copy link
Collaborator Author

cardil commented Jun 27, 2018

Yesterday I made an example PostgreSQL plugin. I pushed it in a branch but I think not to GitHub 🤣.

I repush it today.

cardil pushed a commit that referenced this issue Jun 28, 2018
@cardil
Copy link
Collaborator Author

cardil commented Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants