Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of package names makes that all code needs to switch package names #21

Open
rowtricker opened this issue Nov 22, 2016 · 3 comments

Comments

@rowtricker
Copy link

I only recently noticed that all package names have been switched from camelCase to lower case in the development branch. However, this means that all old code that would like to benefit from the most recent bug fixes will have to switch all package names. Moreover, when switching back for some other reason, all changes will have to be reverted again.

Would it maybe be possible to delay the switch of package names to a major version bump, such that bug fixes in the development branch can be used in old code without the need to change all package names, which is quite some work with very little benefit for the user? Maybe such a major version change can, for example, be made when adding the column manager and parallel framework, as these are changes that will require changes to the public API anyhow.

@rowtricker
Copy link
Author

By the way: cutGeneration under package master currently does not confirm to using lower case

@jkinable
Copy link
Collaborator

Is this still problematic for you? Someone else commented on those camelCase package names since they apparently break java convention. Better to get rid of them as early as possible in the process.

@rowtricker
Copy link
Author

Well, I have now switched my own code to the new package names. So, I don't really mind anymore. But, the main issue was that it was quite difficult to switch from the released code to the development branch in this way and vice versa. I agree that it is indeed good to follow the convention here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants