Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalizing Data.json with fewer parameters #179

Open
ashishk1331 opened this issue Oct 9, 2022 · 2 comments
Open

Formalizing Data.json with fewer parameters #179

ashishk1331 opened this issue Oct 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ashishk1331
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In Data.json file, each user data is structured as

{
    "name": "Arpit Ghura", 
    "username": "arpitghura",
    "avatar": "https://github.com/arpitghura.png"
},

The avatar_url only requires the username as the filling parameter. The URL can be constructed using username only like,

   url = https://github.com/${ username }.png

Describe the solution you'd like
I would like to change the data schema to

{
     "name": "Arpit Ghura",
     "username": "arpitghura"
 }

This would reduce the code size and create fewer errors while adding details.
Also, a custom script to update the initial dataJSON file to adhere to the new data schema.
As well, adapt the serving code to process the avatar image using username only.

Describe alternatives you've considered
Leave the code as it is. As it works fine!

Additional context
I can help develop this feature. I do have a good knowledge of python (which I can use for that script) and I also know javascript, being a JAM-stack developer. Or I can only use Javascript to process all. Plus, I'm good at chores such as data manipulation.

@ashishk1331 ashishk1331 added the enhancement New feature or request label Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Thank you for contributing to Journey Book. We love you and your Issue ❤️🎉 . Your issues, really help us with our project... Waiting for you to contribute again to Journey Book.

@UlbertAO
Copy link

UlbertAO commented Oct 13, 2022

I would like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants