-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which issues must be closed before 1.0b1 release? #509
Comments
I'd like to have #495 (with pull request #500) merged as it fixes editing the carousel compose model for sited editors without the Manager role as soon as any content dropped on the carousel expires. Can we at least merge finished branches/pull request for carousel in the master before we split of the galleria carousel tile? |
I don't see any other issues to hold it up, though I think Fred's request is reasonable, even if not so practical. However, from using master just now, you do realise that using |
@djowett plone/plone.api@16bc0c7 |
@fredvd what other PR are finished and still open on carousel tile? |
@hvelarde Ah, bad reading of GH history & sorry I had a pin on it for some obscure reason. |
[EDIT: 331 has been fixed, thanks all!] #331? It's been an ugly bug that has been breaking other stuff - and it looks like it may be easy to close since a required fix in plone.app.blocks has been merged by @datakurre and subsequently released in p.a.b 2.0.0. |
@petri including p.a.blocks will drop support for Plone 4.2; we are close to a 1.0b1 release and we don't want to leave some important bug fixes out of it as we have some sites to maintain. I would prefer to defer that for 1.0b2. |
I'll be having another try at testing cover today as it is on current master with our biggest project using it. What work is left for 1.0b1, the separation of galleria and adding a released version of covertile.cycle2 by default with instructions on how to stick to galleria instead? Can I help somewhere with that? |
@fredvd I will work on moving the code later today; please review the list of open issues and try to identify which ones are important but we are missing. |
@petri frankly I don't know if we will ever release a 1.0b1 of this package; my view has changed over the last months and there are 2 issues that I have no resources to deal with right now: removal of carousel and PFG tiles. if we don't find time/resources to deal with that (and is not trivial) I think I would prefer at some point just open a new 2.x branch and get rid of all the crap when support for Plone 5.0 is ready. on the mean time, for a new release I want: support for jQuery 1.9 and test plone.app.blocks 3.x as @datakurre told me we may get compatibility with Plone 4.2 back with that. I'm going to close this issue and work on those, ok? any feed back on which other issues we need to close before a new release is welcome. |
Currently we have around 15 issues marked as open bugs of the package; which of them must be closed for release 1.0b?
For me this are blockers:
Beyond removing carousel tile, is there any other enhancement that must be included in 1.0b1?
All carousel bugs must be ignored and moved to the new covertile.galleria repository:
Are there any other blockers?
The text was updated successfully, but these errors were encountered: