Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fingerprints.py #33013

Closed
wants to merge 1 commit into from
Closed

Update fingerprints.py #33013

wants to merge 1 commit into from

Conversation

namestaketoolong
Copy link

Added Missing Engine Firmware Version for 2020 Subaru Impreza.

Verified fwVersion in routes from Dashcam Mode and Sunny Pilot.

Route: 2e7f34ee218f76b6/00000049--8537e775a3

Added Missing Engine Firmware Version for 2020 Subaru Impreza.

Verified fwVersion in routes from Dashcam Mode and Sunny Pilot.

Route: 2e7f34ee218f76b6/00000049--8537e775a3
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@namestaketoolong
Copy link
Author

namestaketoolong commented Jul 19, 2024

This is my 3rd Attempt to get my engine fw added to the master branch so i can test new OP variants without forking.... I keep deleting the repositories i make so i can fiddle with Subaru Impreza Torque and Driving Models... My main problem with Stock OP in my Subaru is the ACC disengagement. But the steering is much better in Stock OP.

@namestaketoolong
Copy link
Author

Pretty please add my fingerprint. 🤣✌️

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants