-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/rerun: Rerun 0.18 #33188
tools/rerun: Rerun 0.18 #33188
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got this error:
(.venv) macbookair:rerun adeebshihadeh$ ./run.py --demo --qcam
You're requesting more than 1 segment, please be aware that might take a lot of memory
Do you wish to continue? (Y/n): y
[2024-08-06T21:19:23Z INFO re_sdk::spawn] A process is already listening at this address. Assuming it's a Rerun Viewer. addr=0.0.0.0:9876
0%| | 0/13 [00:19<?, ?it/s]
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/opt/homebrew/Cellar/[email protected]/3.12.4/Frameworks/Python.framework/Versions/3.12/lib/python3.12/multiprocessing/pool.py", line 125, in worker
result = (True, func(*args, **kwds))
^^^^^^^^^^^^^^^^^^^
File "/Users/adeebshihadeh/openpilot/openpilot/tools/lib/logreader.py", line 294, in _run_on_segment
return func(self._get_lr(i))
^^^^^^^^^^^^^^^^^^^^^
File "/Users/adeebshihadeh/openpilot/.venv/lib/python3.12/site-packages/rerun_sdk/rerun/__init__.py", line 378, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/Users/adeebshihadeh/openpilot/tools/rerun/run.py", line 121, in _process_log_msgs
rr.log_temporal_batch(
^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'rerun' has no attribute 'log_temporal_batch'
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/adeebshihadeh/openpilot/tools/rerun/./run.py", line 174, in <module>
rerunner.load_data()
File "/Users/adeebshihadeh/openpilot/tools/rerun/./run.py", line 141, in load_data
self.lr.run_across_segments(NUM_CPUS, partial(self._process_log_msgs, self.blueprint))
File "/Users/adeebshihadeh/openpilot/openpilot/tools/lib/logreader.py", line 300, in run_across_segments
for p in tqdm.tqdm(pool.imap(partial(self._run_on_segment, func), range(num_segs)), total=num_segs):
File "/Users/adeebshihadeh/openpilot/.venv/lib/python3.12/site-packages/tqdm/std.py", line 1181, in __iter__
for obj in iterable:
File "/opt/homebrew/Cellar/[email protected]/3.12.4/Frameworks/Python.framework/Versions/3.12/lib/python3.12/multiprocessing/pool.py", line 873, in next
raise value
AttributeError: module 'rerun' has no attribute 'log_temporal_batch'
I'm assuming it's because this doesn't install 0.18? Let's just ship that hack you had in the other PR, then remove it once 0.18 is released.
Ah didn't realize you marked that other one as ready for review. Next time you can just do it all in one PR. |
old-commit-hash: a604dcc
This logs everything within 30-35s on my machine and final memory usage is about 2.5GB