Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add car interfacing class #33197

Closed
wants to merge 8 commits into from
Closed

Add car interfacing class #33197

wants to merge 8 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Aug 6, 2024

Doesn't quite make sense to put this inside CarInterfaceBase, as the child classes import from the base class file, causing circular import errors.

@sshane sshane marked this pull request as ready for review August 6, 2024 02:33
@github-actions github-actions bot added the car vehicle-specific label Aug 6, 2024
@sshane sshane added the refactor label Aug 6, 2024
@sshane
Copy link
Contributor Author

sshane commented Aug 12, 2024

don't need a class just yet: #33208

@sshane sshane closed this Aug 12, 2024
@sshane sshane deleted the no-capnp-cars branch August 12, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant