Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of openpilot.common.numpy_fast #34331

Open
adeebshihadeh opened this issue Jan 6, 2025 · 3 comments
Open

Get rid of openpilot.common.numpy_fast #34331

adeebshihadeh opened this issue Jan 6, 2025 · 3 comments

Comments

@adeebshihadeh
Copy link
Contributor

This optimization likely no longer makes sense in the post comma two world. After it's done, we should do some casual profiling to make sure we really don't need it.

It should also be removed from opendbc.

@adeebshihadeh adeebshihadeh changed the title Get rid of openpilot.common.numpy_fast Get rid of openpilot.common.numpy_fast Jan 6, 2025
@adeebshihadeh
Copy link
Contributor Author

I see in #34332 that there's tons of casts from numpy to Python types. Can we just patch pycapnp to handle this for us?

@Shaikimram
Copy link

hey @adeebshihadeh, I would like to take up this issue.

@sunnyhaibin
Copy link
Contributor

hey @adeebshihadeh, I would like to take up this issue.

Open a PR. You do not need to request for permission to work on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Open
Development

No branches or pull requests

3 participants